fix(formDataToJSON): prevent nested arrays for duplicate FormData keys#7536
Closed
Mridul012 wants to merge 1 commit intoaxios:v1.xfrom
Closed
fix(formDataToJSON): prevent nested arrays for duplicate FormData keys#7536Mridul012 wants to merge 1 commit intoaxios:v1.xfrom
Mridul012 wants to merge 1 commit intoaxios:v1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Author
|
Hi Just following up on this PR. Please let me know if any changes or additional tests are needed. Happy to update accordingly. Thanks! |
Member
|
Thanks for the contribution im going to close in favour of a combined fix in #10676 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in
formDataToJSONwhere multiple entries with the same key result in nested arrays instead of a flat array.Problem
When a FormData object contains more than two entries with the same key:
formData.append('file', 'A');
formData.append('file', 'B');
formData.append('file', 'C');
The current implementation produces:
[[A, B], C]
Instead of the expected:
[A, B, C]
Fix
Ensure that values are appended to an existing array instead of wrapping repeatedly:
if (utils.hasOwnProp(target, name)) {
if (utils.isArray(target[name])) {
target[name].push(value);
} else {
target[name] = [target[name], value];
}
}
Impact
Verification
Tested locally by appending multiple values with the same key and confirming output is a flat array.
Summary by cubic
Fixes
formDataToJSONso repeated FormData keys produce a flat array (e.g., [A, B, C]) instead of nested arrays. Improves consistency with common FormData semantics.Description
Ensures duplicate keys append to an existing array, rather than wrapping multiple times.
lib/helpers/formDataToJSON.js, push totarget[name]if it’s already an array; otherwise wrap once as[existing, value].package-lock.jsonupdated (peer flags and minor cleanup). No runtime impact.Docs
formDataToJSONdocs to clarify: repeated keys return a flat array in insertion order.Testing
File,Blob, string) with duplicates remain flat and ordered.Written for commit 1c33ad5. Summary will update on new commits.