Repository navigation
Skip validation on delete requests #318 - #330
Merged
anshikg merged 2 commits intoMar 2, 2021
Merged
Conversation
wbingli
reviewed
Nov 12, 2020
wbingli
left a comment
There was a problem hiding this comment.
Is this only for contract test? I believe in Cloudformation a full resource model is passed for the delete handler.
Contributor
Author
Let me double check on this assumption and get back to you. |
|
Even CFN pass the full model to the DELETE, it doesn't make sense to make validation for the resource model, especially for the writeOnly properties. It only makes sense to do a full model validation for CREATE/UPDATE. |
wbingli
approved these changes
Feb 26, 2021
anshikg
approved these changes
Feb 26, 2021
ammokhov
approved these changes
Feb 26, 2021
Contributor
|
Did you run any manual tests? Did you make sure it does not cause any regression? |
anshikg
force-pushed
the
skip-delete-validate
branch
from
March 2, 2021 03:08
a8d2e9d to
5e93292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #318
Description of changes: Certain properties that are marked writeOnly and required will cause validation errors on delete, as the primaryIdentifier is only passed to the delete handlers. This PR removes the requirement to validate incoming payloads on deletion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.