Fix first part response validation in parallel presigned URL multipart subscriber#7013
Open
jencymaryjoseph wants to merge 1 commit into
Conversation
9e0238b to
3e827cf
Compare
3e827cf to
a652a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ParallelPresignedUrlMultipartDownloaderSubscriberdid not validate the first part's response metadata (Content-Length, Content-Range alignment). Parts 1+ were validated via validatePartResponse(), but part 0 only checked whether Content-Range was parseable — it never verified that the returned byte range and content length matched expectations.PresignedUrlMultipartDownloaderSubscriberhad a misleading counter namedcompletedPartsthat was actually used as a part index assignment counter (incremented before the request, not after completion)Modifications
Also renamed isCompletedExceptionally → downloadFailed for clarity and to avoid confusion with
java.util.concurrent.CompletableFuture.isCompletedExceptionally()Removed redundant CompletableFutureUtils.forwardExceptionTo — handlePartError already completes resultFuture and cancels in-flight requests
PresignedUrlMultipartDownloaderSubscriber— the counter was incremented before the request was sent (to assign a part index), not after completion. The old name implied parts had finished downloading, which was misleading.PresignedUrlDownloadHelperMoved calculateTotalParts() to
MultipartDownloadUtilsto eliminate duplication across both subscribersTesting
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License