Skip to content

Improve Exception Output for run with Missing Handler#70

Merged
zsombor-balogh merged 1 commit intoaws:mainfrom
jackcasey-visier:missing-handler-error-handling
May 25, 2022
Merged

Improve Exception Output for run with Missing Handler#70
zsombor-balogh merged 1 commit intoaws:mainfrom
jackcasey-visier:missing-handler-error-handling

Conversation

@jackcasey-visier
Copy link
Copy Markdown
Contributor

@jackcasey-visier jackcasey-visier commented Mar 2, 2022 •
edited
Loading

Summary

This change improves the error handling when running awslambdaric without a handler. Currently, the exception thrown is fairly non-specific:

python -m awslambdaric

Traceback (most recent call last):
  File "python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "awslambdaric/__main__.py", line 20, in <module>
    main(sys.argv)
  File "awslambdaric/__main__.py", line 13, in main
    handler = args[1]
IndexError: list index out of range

The changes make the output a bit more human friendly 😄 :

python -m awslambdaric

Traceback (most recent call last):
  File "python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "awslambdaric/__main__.py", line 25, in <module>
    main(sys.argv)
  File "awslambdaric/__main__.py", line 17, in main
    raise ValueError("Handler not set")
ValueError: Handler not set

Even with the changes in place the module exists with an unhandled exception in the same way. We may want to wrap this to provide a more clean exit 😅

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

zsombor-balogh
zsombor-balogh approved these changes May 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@zsombor-balogh zsombor-balogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@jackcasey-visier
Copy link
Copy Markdown
Contributor Author

jackcasey-visier commented May 4, 2022 •
edited
Loading

@zsombor-balogh My pleasure!

@jackcasey-visier
Copy link
Copy Markdown
Contributor Author

jackcasey-visier commented May 24, 2022

@zsombor-balogh @carlzogh Friendly poke :)

Just curious, is there anything I can do to help move this forward? Is there testing that needs to be accomplished?

Thanks!

@zsombor-balogh zsombor-balogh merged commit 020fa7a into aws:main May 25, 2022
@zsombor-balogh
Copy link
Copy Markdown
Contributor

zsombor-balogh commented May 25, 2022

@zsombor-balogh @carlzogh Friendly poke :)

Just curious, is there anything I can do to help move this forward? Is there testing that needs to be accomplished?

Thanks!

Apologies for the delay, merged it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@carlzogh carlzogh carlzogh approved these changes

@zsombor-balogh zsombor-balogh zsombor-balogh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackcasey-visier @zsombor-balogh @carlzogh