Add Log4J 2 Logging Support#7
Closed
ThatJoeMoore wants to merge 2 commits intoaws:masterfrom
ThatJoeMoore:master
Closed
Add Log4J 2 Logging Support#7ThatJoeMoore wants to merge 2 commits intoaws:masterfrom ThatJoeMoore:master
ThatJoeMoore wants to merge 2 commits intoaws:masterfrom
ThatJoeMoore:master
Conversation
added 2 commits
March 9, 2016 22:33
|
I tried this and it worked as expected! I needed to make one small tweak with the default encoding. Much appreciated. |
| } | ||
|
|
||
| public void append(LogEvent event) { | ||
| logger.log(new String(getLayout().toByteArray(event))); |
There was a problem hiding this comment.
Recommend ensuring some sort of reasonable encoding here: UTF-8?
agentgonzo
approved these changes
Jun 1, 2017
|
Guys, let's merge this PR. We need log4j2! |
Contributor
|
Added support in last commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I left out the call to LambdaRuntimeInternal.setUseLog4jAppender, as I don't know what effect that has and what consequences including it would have.