Added Rain Alert Mail Sender by Shubhrima · Pull Request #997 · avinashkranjan/Amazing-Python-Scripts

Shubhrima · 2021-04-30T03:27:26Z

Description

An application that checks the weather condition for the next 12 hours and sends a message to the registered mail address number as to whether one should carry a sunglass (if it is sunny) , or an umbrella (if it rains).

Fixes #993

Have you read the Contributing Guidelines on Pull Requests?

Yes
No

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist:

[ x] My code follows the style guidelines(Clean Code) of this project
[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[ x] I have created a helpful and easy to understand README.md
[ x] My documentation follows Template for README.md
[x ] My changes generate no new warnings
[x ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.
[x ] I have added the project meta data in the PR template.
[x ] I have created the requirements.txt file if needed

Project Metadata

If there is no-file/nothing to fill the below fields with, then type: none

Example: If no requirements.txt needed/present, then type none in Requirments.

Category:

Title: Rain Alert Mail Sender

Folder: Rain Alert Mail Sender

Requirements: requirements.txt

Script: main.py

Arguments: none

Contributor: Shubhrima

Description: An application that alerts about the weather for the next 12 hours.

kaustubhgupta · 2021-05-01T04:02:00Z

+MY_MAIL= ENTER_YOUR_MAIL
+MY_PASSWORD= ENTER_YOUR_PASSWORD
+RECIEVER_MAIL = RECIEVER_MAIL


Get these inputs from user using input function

kaustubhgupta · 2021-05-01T04:03:56Z

+LAT = 22.572645
+LONG = 88.363892


What are these coordinates for? If you're using them for location then get the location from the user and then use https://nominatim.openstreetmap.org/search/ to get the exact coordinates of the location

kaustubhgupta · 2021-05-01T04:04:14Z

+LAT = 22.572645
+LONG = 88.363892
+
+API_KEY = API


get it from user

Shubhrima · 2021-05-01T05:15:37Z

@kaustubhgupta please check

kaustubhgupta · 2021-05-02T03:48:22Z

+RECIEVER_MAIL = input('Send mail to (mail id): ')
+CITY = input('Enter your City: ')
+
+API_KEY = input('Type in API from OpenWeather: ')


Suggested change

API_KEY = input('Type in API from OpenWeather: ')

API_KEY = input('Type in API key from OpenWeather: ')

kaustubhgupta · 2021-05-02T03:55:11Z

+if (bring_umbrella == True):
+    with SMTP("smtp.gmail.com") as connection:
+        connection.starttls()
+        connection.login(user=MY_MAIL, password=MY_PASSWORD)
+        connection.sendmail(from_addr=MY_MAIL, to_addrs=RECIEVER_MAIL,
+                            msg=f"Subject: Rain Rain \n\nIt's going to rain today. Bring Umbrella ")
+        print('Mail Sent')
+else:
+    with SMTP("smtp.gmail.com") as connection:
+        connection.starttls()
+        connection.login(user=MY_MAIL, password=MY_PASSWORD)
+        connection.sendmail(from_addr=MY_MAIL, to_addrs='shubhrijana@gmail.com',
+                            msg=f"Subject: Sunny Day\n\nMay be a sunny day. Carry sunglasses. ")
+        print('Mail Sent')


Instead of duplicating the code for making a Gmail connection, the only thing that changes in if-else is the msg content. So, in if-else statements, just modify the message variable and then sent the message. This is what I mean to say:

if umbrella: msg = Subject: Rain Rain \n\nIt's going to rain today. Bring Umbrella else: msg = Subject: Sunny Day\n\nMay be a sunny day. Carry sunglasses. with SMTP("smtp.gmail.com") as connection: connection.sendmail(from_addr=MY_MAIL, to_addrs=RECIEVER_MAIL, msg=msg)

Shubhrima · 2021-05-03T12:24:49Z

@kaustubhgupta please check

kaustubhgupta · 2021-05-04T03:30:29Z

+MY_MAIL= input('Enter your mail id: ')
+MY_PASSWORD= input('Enter password: ')
+RECIEVER_MAIL = input('Send mail to (mail id): ')
+#get latitude longitude from  "https://www.latlong.net/"


remove this comment

kaustubhgupta · 2021-05-04T03:31:08Z

+import requests
+from smtplib import SMTP
+
+#turn off certain security criteria in sender mail address


What type of security criteria? Kindly mention them as doc string

@kaustubhgupta done.

Kushal997-das

LGTM 💯

antrikshmisri

Instead of taking inputs for every variable, you can take the values from a .env file.

Shubhrima · 2021-05-04T14:53:26Z

Instead of taking inputs for every variable, you can take the values from a .env file.

Please Check

kaustubhgupta

@Shubhrima Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002

Shubhrima · 2021-05-14T03:39:26Z

@Shubhrima Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002

please check

kaustubhgupta

PR template is wrongly filled. Please check other approved PRs for better understanding

Shubhrima · 2021-05-14T05:10:11Z

PR template is wrongly filled. Please check other approved PRs for better understanding

Is it okay now?

github-actions · 2021-05-23T02:45:44Z

Due to inactivity this pull request has been marked as stale.

Shubhrima Jana and others added 2 commits April 30, 2021 08:50

Added Rain Alert Mail Sender

3c5c6aa

Update README.md

2853b8d

kaustubhgupta suggested changes May 1, 2021

View reviewed changes

kaustubhgupta added bug Something isn't working enhancement New feature or request labels May 1, 2021

made necessary changes

65fcb01

kaustubhgupta suggested changes May 2, 2021

View reviewed changes

Shubhrima added 2 commits May 2, 2021 12:17

Update main.py

188acc3

Update main.py

2f7fd44

kaustubhgupta suggested changes May 4, 2021

View reviewed changes

Shubhrima added 2 commits May 4, 2021 09:08

Update main.py

580c9fc

Update main.py

afaf8cf

kaustubhgupta approved these changes May 4, 2021

View reviewed changes

kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working enhancement New feature or request labels May 4, 2021

kaustubhgupta requested review from antrikshmisri and santushtisharma10 May 4, 2021 04:58

Kushal997-das approved these changes May 4, 2021

View reviewed changes

antrikshmisri suggested changes May 4, 2021

View reviewed changes

Update main.py

3df81f9

antrikshmisri approved these changes May 4, 2021

View reviewed changes

santushtisharma10 approved these changes May 5, 2021

View reviewed changes

santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features and removed next review needed Approved by some mentors, more approvals needed labels May 5, 2021

kaustubhgupta suggested changes May 11, 2021

View reviewed changes

kaustubhgupta added hold Needs a second thought and removed Approved PR Approved and Ready to Merge labels May 11, 2021

Added requirements

1807d9b

kaustubhgupta reviewed May 14, 2021

View reviewed changes

kaustubhgupta approved these changes May 15, 2021

View reviewed changes

kaustubhgupta added Approved PR Approved and Ready to Merge and removed hold Needs a second thought labels May 15, 2021

github-actions Bot added the Stale PRs with no updates label May 23, 2021

kaustubhgupta added manual-db-update-req The PR was merged but db was not updated. Need to update the database manully and removed Stale PRs with no updates labels May 23, 2021

kaustubhgupta merged commit 44a71e7 into avinashkranjan:master May 27, 2021

	API_KEY = input('Type in API from OpenWeather: ')
	API_KEY = input('Type in API key from OpenWeather: ')

		LAT = 22.572645
		LONG = 88.363892

Uh oh!

Conversation

Shubhrima commented Apr 30, 2021 • edited by kaustubhgupta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixes #993

Have you read the Contributing Guidelines on Pull Requests?

Type of change

Checklist:

Project Metadata

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shubhrima commented May 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Shubhrima commented May 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kushal997-das left a comment

Choose a reason for hiding this comment

Uh oh!

antrikshmisri left a comment

Choose a reason for hiding this comment

Uh oh!

Shubhrima commented May 4, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Shubhrima commented May 14, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Shubhrima commented May 14, 2021

Uh oh!

github-actions Bot commented May 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Shubhrima commented Apr 30, 2021 •

edited by kaustubhgupta

Loading