Skip to content

Beat board#990

Merged
kaustubhgupta merged 13 commits into
avinashkranjan:masterfrom
albertzeap:beatBoard
May 21, 2021
Merged

Beat board#990
kaustubhgupta merged 13 commits into
avinashkranjan:masterfrom
albertzeap:beatBoard

Conversation

@albertzeap

@albertzeap albertzeap commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Description

Created a beat board which allows the user to activate specific sounds based on the
button or key pressed.

Fixes #944

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Project Metadata

If there is no-file/nothing to fill the below fields with, then type none:
Example: If no requirements.txt needed/present then type in Requirements none => Requirements: none

Category:

  • Calculators
  • AI/ML
  • Scrappers
  • Social Media
  • PDF
  • Image_Processing
  • Video_Processing
  • Games
  • Networking
  • OS_Utilities
  • Automation
  • Cryptography
  • Computer_Vision
  • Fun
  • Others

Title: Beat_Board

Folder: Beat-Board

Requirements: requirements.txt

Script: beatBoard.py

Arguments: none

Contributor: albertzeap

Description: A small GUI program that allows the user to create custom sounds through mouse clicks or key presses.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

Comment thread Beat-Board/README Outdated
Comment thread Beat-Board/beatBoard.py Outdated
@kaustubhgupta kaustubhgupta added the bug Something isn't working label May 6, 2021

@kaustubhgupta kaustubhgupta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool project! I loved playing with the beats!

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels May 8, 2021

@santushtisharma10 santushtisharma10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaustubhgupta kaustubhgupta requested review from antrikshmisri and avinashkranjan and removed request for antrikshmisri May 11, 2021 04:40
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge hold Needs a second thought and removed next review needed Approved by some mentors, more approvals needed Approved PR Approved and Ready to Merge labels May 12, 2021

@kaustubhgupta kaustubhgupta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertzeap Add the requirements.txt file and update the PR template with project metadata. Refer to this PR for implementation: #1002

@albertzeap

Copy link
Copy Markdown
Contributor Author

@albertzeap Add the requirements.txt file and update the PR template with project metadata. Refer to this PR for implementation: #1002

I edited the PR to match the template of the implementation. I was wondering what needed to be in the requirements.txt file? Would it just be the playsound module that I used?

@kaustubhgupta

Copy link
Copy Markdown
Contributor

@albertzeap Add the requirements.txt file and update the PR template with project metadata. Refer to this PR for implementation: #1002

I edited the PR to match the template of the implementation. I was wondering what needed to be in the requirements.txt file? Would it just be the playsound module that I used?

Yes, we need the requirements file for master script

@albertzeap

Copy link
Copy Markdown
Contributor Author

@albertzeap Add the requirements.txt file and update the PR template with project metadata. Refer to this PR for implementation: #1002

I edited the PR to match the template of the implementation. I was wondering what needed to be in the requirements.txt file? Would it just be the playsound module that I used?

Yes, we need the requirements file for master script

Alright I just created the requirements.txt

Comment thread Beat-Board/requirements.txt Outdated
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge and removed hold Needs a second thought labels May 15, 2021
@kaustubhgupta kaustubhgupta merged commit 6b093b4 into avinashkranjan:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved PR Approved and Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beat Board

3 participants