Skip to content

TextSentimentalAnalysisScipt#958

Merged
kaustubhgupta merged 23 commits into
avinashkranjan:masterfrom
shantamsultania:TextSentimentalAnalysisScipt
May 24, 2021
Merged

TextSentimentalAnalysisScipt#958
kaustubhgupta merged 23 commits into
avinashkranjan:masterfrom
shantamsultania:TextSentimentalAnalysisScipt

Conversation

@shantamsultania
Copy link
Copy Markdown
Contributor

@shantamsultania shantamsultania commented Apr 24, 2021

Description

A GUI that will allow you to convert perform Sentimental analysis on a particular text entered by the user

Fixes #(issue_no)

Fixes: #211

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • [x ] My code follows the style guidelines(Clean Code) of this project
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have created a helpful and easy to understand README.md
  • [x ] My documentation follows Template for README.md
  • I have added the project meta data in the PR template.
  • [x ] I have created the requirements.txt file if needed.

Project Metadata

If there is no-file/nothing to fill the below fields with, then type: none

Example: If no requirements.txt needed/present, then type none in Requirments.

Category:

  • Calculators
  • AI/ML
  • Scrappers
  • Social_Media
  • PDF
  • Image_Processing
  • Video_Processing
  • Games
  • Networking
  • OS_Utilities
  • Automation
  • Cryptography
  • Computer_Vision
  • Fun
  • Others

Title: Text Sentimental Analysis

Folder: Text_Sentimental_Analysis_Script_with_GUI

Requirements: none

Script: app.py

Arguments: none

Contributor: shantamsultania

Description: A GUI that will allow you to convert perform Sentimental analysis on a particular text entered by the user

@shantamsultania shantamsultania marked this pull request as draft April 24, 2021 11:09
@shantamsultania
Copy link
Copy Markdown
Contributor Author

No description provided.

@shantamsultania shantamsultania marked this pull request as ready for review April 24, 2021 13:13
@shantamsultania
Copy link
Copy Markdown
Contributor Author

@kaustubhgupta @antrikshmisri any suggestion in the same ?

Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs:

  • The folder name has wrong spelling of Script, Text-Sentimental-Analysis-Scipt-with-GUI/. Kindly correct that. I am assuming that you have corrected that and based on this correction, I am suggesting these next steps.

  • Add a blank __init__.py file inside the Text-Sentimental-Analysis-Script-with-GUI folder so that this becomes package and you can directly call the Model. I have suggested the same in the code.

  • For some reason, this simple line is not getting any sentiment and throwing this error:
    image

final_words.append(word)

emotion_list = []
with open('textFiles/emotions.txt', 'r') as file:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with open('textFiles/emotions.txt', 'r') as file:
with open('./Text-Sentimental-Analysis-Script-with-GUI/textFiles/emotions.txt', 'r') as file:


root.resizable(False, False)

image = PhotoImage(file="images/background.png")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image = PhotoImage(file="images/background.png")
image = PhotoImage(file="./Text-Sentimental-Analysis-Script-with-GUI/images/background.png")


enterWordEntry.focus_set()

searchImage = PhotoImage(file='images/search.png')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
searchImage = PhotoImage(file='images/search.png')
searchImage = PhotoImage(file='./Text-Sentimental-Analysis-Script-with-GUI/images/search.png')

@@ -0,0 +1,47 @@
import textSentimentalAnalysisWebApp.Model
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import textSentimentalAnalysisWebApp.Model
import Model

word = enterWordEntry.get()

text = word.strip()
model_object = textSentimentalAnalysisWebApp.Model.model()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
model_object = textSentimentalAnalysisWebApp.Model.model()
model_object = Model.model()

Copy link
Copy Markdown
Contributor Author

@shantamsultania shantamsultania May 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if all the suggested issues are resolved or not let me know if any more changes are required

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Apr 27, 2021
@shantamsultania
Copy link
Copy Markdown
Contributor Author

hey @kaustubhgupta i will look into this and clear out the changes just stuck with some work so will clear out all the 3 pr changes tomorrow it self

Co-authored-by: Kaustubh Gupta <kaustubhgupta1828@gmail.com>
@shantamsultania
Copy link
Copy Markdown
Contributor Author

done the minor change

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels May 8, 2021
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels May 10, 2021
Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shantamsultania Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002

@kaustubhgupta kaustubhgupta added hold Needs a second thought and removed Approved PR Approved and Ready to Merge labels May 11, 2021
@shantamsultania
Copy link
Copy Markdown
Contributor Author

@shantamsultania Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002

please check the requested changes as tkinter is preinstalled I don't think it requires any requirements.txt file

@kaustubhgupta
Copy link
Copy Markdown
Contributor

@shantamsultania Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002

please check the requested changes as tkinter is preinstalled I don't think it requires any requirements.txt file

oh, got it

@kaustubhgupta
Copy link
Copy Markdown
Contributor

@shantamsultania The PR template has been updated wrongly. Refer to approved PRs or the one I pointed in the above message. The category is missing.

@shantamsultania
Copy link
Copy Markdown
Contributor Author

hey @kaustubhgupta i have updated the template please check now

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge and removed hold Needs a second thought labels May 12, 2021
@github-actions
Copy link
Copy Markdown

Due to inactivity this pull request has been marked as stale.

@github-actions github-actions Bot added the Stale PRs with no updates label May 20, 2021
@kaustubhgupta kaustubhgupta removed the Stale PRs with no updates label May 20, 2021
@kaustubhgupta kaustubhgupta merged commit 03d169d into avinashkranjan:master May 24, 2021
@kaustubhgupta kaustubhgupta added the manual-db-update-req The PR was merged but db was not updated. Need to update the database manully label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing manual-db-update-req The PR was merged but db was not updated. Need to update the database manully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A script that will check sentiment for an input text without any external lib [GUI]

4 participants