Skip to content

Drs Gully System#953

Closed
Ayush7614 wants to merge 2 commits into
avinashkranjan:masterfrom
Ayush7614:master
Closed

Drs Gully System#953
Ayush7614 wants to merge 2 commits into
avinashkranjan:masterfrom
Ayush7614:master

Conversation

@Ayush7614
Copy link
Copy Markdown
Contributor

@Ayush7614 Ayush7614 commented Apr 22, 2021

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #914

Replace #914 with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@@ -0,0 +1,28 @@
# Drs Gully System

# About this Project
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# About this Project
## About this Project

# About this Project
One of the most treasured memories of growing up is playing cricket with friends. Just like me, there are countless other people whose favourite part of the day is to grab a pair of bat and ball and just play. Gully cricket is the most popular form of sport, is played in everywhere. So, today’s project is going to be very helpful for those cricket fans who want to create their own decision review system.

# Features
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Features
## Features

# Features
The third empire takes the decision about no-ball, runout, or catch out. Here we are going to make the decision review system using python which will take an accurate decison aboutwheather the batsman is out or not out.

# How to Run
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# How to Run
## How to Run


# How to Run

1. Run the installation script
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, I think these instructions have nothing to do with this script. There is no file named install.py and no Enter installation directory: project_dir. Kindly check these and update according to the script pushed

Comment thread Drs Gully System/main.py
import time
import imutils # pip install imutils

stream = cv2.VideoCapture("clip.mp4")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the input from the user for the video path

Comment thread Drs Gully System/main.py
time.sleep(2.5)
# 5. Display out/notout image
if decision == 'out':
decisionImg = "out.jpg"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
decisionImg = "out.jpg"
decisionImg = "./Drs Gully System/out.jpg"

Comment thread Drs Gully System/main.py
if decision == 'out':
decisionImg = "out.jpg"
else:
decisionImg = "not_out.jpg"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
decisionImg = "not_out.jpg"
decisionImg = "./Drs Gully System/not_out.jpg"

Comment thread Drs Gully System/main.py

def pending(decision):
# 1. Display decision pending image
frame = cv2.cvtColor(cv2.imread("pending.jpg"), cv2.COLOR_BGR2RGB)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
frame = cv2.cvtColor(cv2.imread("pending.jpg"), cv2.COLOR_BGR2RGB)
frame = cv2.cvtColor(cv2.imread("./Drs Gully System/pending.jpg"), cv2.COLOR_BGR2RGB)

Comment thread Drs Gully System/main.py
time.sleep(1.5)

# 3. Display sponsor image
frame = cv2.cvtColor(cv2.imread("sponsor.jpg"), cv2.COLOR_BGR2RGB)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
frame = cv2.cvtColor(cv2.imread("sponsor.jpg"), cv2.COLOR_BGR2RGB)
frame = cv2.cvtColor(cv2.imread("./Drs Gully System/sponsor.jpg"), cv2.COLOR_BGR2RGB)

Comment thread Drs Gully System/main.py
# Tkinter gui starts here
window = tkinter.Tk()
window.title(" Third Umpire Decision Review Kit")
cv_img = cv2.cvtColor(cv2.imread("welcome.jpg"), cv2.COLOR_BGR2RGB)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cv_img = cv2.cvtColor(cv2.imread("welcome.jpg"), cv2.COLOR_BGR2RGB)
cv_img = cv2.cvtColor(cv2.imread("./Drs Gully System/welcome.jpg"), cv2.COLOR_BGR2RGB)

@kaustubhgupta
Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Apr 23, 2021
@kaustubhgupta
Copy link
Copy Markdown
Contributor

@Ayush7614 updates on this?

@kaustubhgupta
Copy link
Copy Markdown
Contributor

@Ayush7614 Will you update this PR today?

@kaustubhgupta kaustubhgupta added the hold Needs a second thought label Apr 27, 2021
@kaustubhgupta
Copy link
Copy Markdown
Contributor

PR and issue closed due to no response from participant side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hold Needs a second thought

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Third Umpire Decision Review System DRS Gully Cricket

2 participants