Skip to content

Health log book#830

Merged
avinashkranjan merged 7 commits into
avinashkranjan:masterfrom
anuragmukherjee2001:health_log_book
Apr 19, 2021
Merged

Health log book#830
avinashkranjan merged 7 commits into
avinashkranjan:masterfrom
anuragmukherjee2001:health_log_book

Conversation

@anuragmukherjee2001
Copy link
Copy Markdown
Contributor

Description

The script will contain the daily records of food and workouts of a person. The user will only enter the name of the foods, it will be stored in a text file with corresponding date and time. Similarly, the user will enter the types of workout at their workout time. The workouts will be stored in a text file with date and time. The user can also retrieve the data whenever they want to see.

Modules Used:-

  1. datetime

Fixes #823

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a GUI application for this. The current code is not up to the mark for level 2. Also, instead of text files, use mysqlite to store details. If you don't have any experience for that then we need to decrease the level.

Thoughts? @antrikshmisri @santushtisharma10

Comment thread Health_Log_Book/README.md Outdated
1) datetime

### Images of the script:-
<img src = "https://user-images.githubusercontent.com/62845847/113548479-3998f980-960d-11eb-806b-4321cec05a98.png" width = "400" height = "300">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the complete image of the script and therefore you can remove this image. Remove this section heading too.

Comment thread Health_Log_Book/main.py Outdated
@@ -0,0 +1,46 @@
# It is a health management system
Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these 4 line comment and unnecessary comments from the script

@kaustubhgupta kaustubhgupta added the hold Needs a second thought label Apr 6, 2021
@antrikshmisri
Copy link
Copy Markdown
Contributor

Create a GUI application for this. The current code is not up to the mark for level 2. Also, instead of text files, use mysqlite to store details. If you don't have any experience for that then we need to decrease the level.

Thoughts? @antrikshmisri @santushtisharma10

Agreed.

@anuragmukherjee2001
Copy link
Copy Markdown
Contributor Author

Ok sir, I will try to do all the suggested changes. As lots of changes are suggested, so it may take some time. And 1 question sir, can I use SQLite??
@antrikshmisri @santushtisharma10 @kaustubhgupta

@santushtisharma10
Copy link
Copy Markdown
Contributor

Ok sir, I will try to do all the suggested changes. As lots of changes are suggested, so it may take some time. And 1 question sir, can I use SQLite??
@antrikshmisri @santushtisharma10 @kaustubhgupta

Yes

@kaustubhgupta
Copy link
Copy Markdown
Contributor

@anuragmukherjee2001 updates on this?

@anuragmukherjee2001
Copy link
Copy Markdown
Contributor Author

@anuragmukherjee2001 updates on this?

Yes sir, I am making the suggested changes. I will push the changes within tomorrow.

Added the database and implemented the script with as a GUI application
Creating a database.py file for storing all the queries which will be required for our database work.
@anuragmukherjee2001
Copy link
Copy Markdown
Contributor Author

I updated the code. Please check it sir.

Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I click on show exercise/food log without entering any information, an exception is raised:

Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Users\Lenovo\anaconda3\lib\tkinter\__init__.py", line 1705, in __call__
    return self.func(*args)
  File "d:/Projects/Amazing-Python-Scripts/Health_Log_Book/main.py", line 54, in show_food
    cor.execute('''SELECT * from food''')
sqlite3.OperationalError: no such table: food

Handle this case by giving popup that "No information available"

Also, on clicking show log, the information is printed in the terminal. Display that information in the application GUI only. Create a text area called results to show them

@kaustubhgupta kaustubhgupta added bug Something isn't working and removed hold Needs a second thought labels Apr 9, 2021
@anuragmukherjee2001
Copy link
Copy Markdown
Contributor Author

Ok sir, trying to correct the mistakes

@kaustubhgupta
Copy link
Copy Markdown
Contributor

@anuragmukherjee2001 updates?

@anuragmukherjee2001
Copy link
Copy Markdown
Contributor Author

@anuragmukherjee2001 updates?

I corrected the case which was giving an error. I am working on the feature of showing the information on GUI.

@anuragmukherjee2001
Copy link
Copy Markdown
Contributor Author

I have made all the changes which were suggested. Please Check the PR.

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Apr 15, 2021
@santushtisharma10 santushtisharma10 removed the next review needed Approved by some mentors, more approvals needed label Apr 16, 2021
@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features labels Apr 16, 2021
Copy link
Copy Markdown
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinashkranjan avinashkranjan merged commit 3f0dd7a into avinashkranjan:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Health Log Book

5 participants