Added Battery Notification Script by pankaj892 · Pull Request #746 · avinashkranjan/Amazing-Python-Scripts

pankaj892 · 2021-03-26T11:52:36Z

Description

This script notifies the user about the battery percentage left

Fixes #727

Have you read the Contributing Guidelines on Pull Requests?

Yes
No

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Documentation Update

Checklist:

My code follows the style guidelines(Clean Code) of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have created a helpful and easy to understand README.md
My documentation follows Template for README.md
My changes generate no new warnings
I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

santushtisharma10 · 2021-03-26T15:12:23Z

+```
+## Run the program using command
+


Suggested change

```

## Run the program using command

Run the program using command

santushtisharma10 · 2021-03-26T15:12:55Z

@pankaj892 the code is working fine, just a few changes in readme file

Co-authored-by: Santushti Sharma <60578091+santushtisharma10@users.noreply.github.com>

pankaj892 · 2021-03-26T16:04:36Z

@santushtisharma10 I have made the necessary changes please review them

santushtisharma10

@pankaj892 💯

santushtisharma10 · 2021-03-27T05:49:39Z

@Kushal997-das

Kushal997-das

LGTM 💯

kaustubhgupta · 2021-03-27T10:49:31Z

@@ -93,3 +93,4 @@
 | 89\.     | Voice-Assistant  | Voice-Assistant Bot | [Take Me](https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Voice-Assistant) |  [Avinash .K. Rajan](https://github.com/avinashkranjan) |


remove this modification. We are looking to automate this process and therefore this updation is not needed as of now

@kaustubhgupta as mentioned by you i have removed the modification please review and let me know if any further changes are required

kaustubhgupta · 2021-03-28T03:55:51Z

 | 89\.     | Voice-Assistant  | Voice-Assistant Bot | [Take Me](https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Voice-Assistant) |  [Avinash .K. Rajan](https://github.com/avinashkranjan) |
 | 90\.     | Website-Status-Checker  | This script will check the status of the web address which you will input | [Take Me](https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Website-Status-Checker) |  [Avinash .K. Rajan](https://github.com/avinashkranjan) |
-| 91\.     | Movie-Genre-Prediction-Chatbot       | An chatbot will predict the genre of the movie based on the input text. | [Take Me](https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Movie-Genre-Prediction-Chatbot) | [Hritik Jaiswal](https://github.com/hritik5102) |
+| 91\.     | Movie-Genre-Prediction-Chatbot       | An chatbot will predict the genre of the movie based on the input text. | [Take Me](https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Movie-Genre-Prediction-Chatbot) | [Hritik Jais


you have modified the file, revert all the changes in this file to normal

@kaustubhgupta I have made the changes to the file please review

antrikshmisri · 2021-04-07T07:05:05Z

@pankaj892 You just added a timeout but didn't implement the logic. What you need to do is, add logic to only show notification when battery percentage changes. TO avoid the script spamming notification, add a time.sleep just before you compare the current level with the previous level. If any doubt feel free to ask

pankaj892 · 2021-04-08T09:55:40Z

@antrikshmisri I am confused as to how will i determine that there is a change in battery since when i try to measure battery after a delay i am not able to device a logic to find change.I know this doubt might seem silly.Please Help

kaustubhgupta · 2021-04-08T15:10:05Z

@antrikshmisri I am confused as to how will i determine that there is a change in battery since when i try to measure battery after a delay i am not able to device a logic to find change.I know this doubt might seem silly.Please Help

Let me elaborate, store the previous battery level in a variable. When the time for giving notifications comes, compare that time battery level with that variable and define a threshold for this. If the diff in battery level is less than that threshold, don't show notification else show battery status and update that variable with the current level. Dry run example:

threshold = 5%

time: 8:48, battery level: 45%
prev_battery = 45

time: 8:50, battery level: 42%
|42 - 45| = 3 < 5, therefore no notification sent

time: 8:53, battery level: 39%
|39 - 45| = 6 > 5, send notification that "39% battery left"
prev_battery = 39

and so on...

Take the threshold value input from user before running loop

antrikshmisri · 2021-04-08T15:48:25Z

@antrikshmisri I am confused as to how will i determine that there is a change in battery since when i try to measure battery after a delay i am not able to device a logic to find change.I know this doubt might seem silly.Please Help

Let me elaborate, store the previous battery level in a variable. When the time for giving notifications comes, compare that time battery level with that variable and define a threshold for this. If the diff in battery level is less than that threshold, don't show notification else show battery status and update that variable with the current level. Dry run example:

threshold = 5%

time: 8:48, battery level: 45%
prev_battery = 45

time: 8:50, battery level: 42%
|42 - 45| = 3 < 5, therefore no notification sent

time: 8:53, battery level: 39%
|39 - 45| = 6 > 5, send notification that "39% battery left"
prev_battery = 39

and so on...

Take the threshold value input from user before running loop

@pankaj892 implement the algorithm as suggested by @kaustubhgupta

kaustubhgupta · 2021-04-09T12:08:46Z

@pankaj892 did you got my point?

pankaj892 · 2021-04-09T14:52:25Z

@kaustubhgupta I partly understood what you said. As you said I created two different variables holding current battery and battery after time.sleep but I am confused as to where should i use the while loop after comparing i should use the loop to print the battery percentage or i should start the loop before comparing itself.please help me on this?

kaustubhgupta · 2021-04-10T03:40:24Z

start the loop before comparing

pankaj892 · 2021-04-10T08:56:00Z

@antrikshmisri As suggested by you I have made the changes to the script please review.Also @kaustubhgupta thanks for helping

Co-authored-by: Kaustubh Gupta <kaustubhgupta1828@gmail.com>

pankaj892 · 2021-04-11T07:19:04Z

@kaustubhgupta I have made the changes as per your suggestions please review.

Added Battery Notification Script

1a9f064

santushtisharma10 suggested changes Mar 26, 2021

View reviewed changes

Comment thread Battery-Notification/README.md

santushtisharma10 suggested changes Mar 26, 2021

View reviewed changes

santushtisharma10 added the minor-change-not-bug Suggested a minor change in code, not a bug label Mar 26, 2021

pankaj892 and others added 2 commits March 26, 2021 21:31

Update Battery-Notification/README.md

661616e

Co-authored-by: Santushti Sharma <60578091+santushtisharma10@users.noreply.github.com>

Update README.md

f84f18b

santushtisharma10 approved these changes Mar 27, 2021

View reviewed changes

santushtisharma10 requested a review from kaustubhgupta March 27, 2021 05:47

santushtisharma10 added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Mar 27, 2021

Kushal997-das approved these changes Mar 27, 2021

View reviewed changes

kaustubhgupta suggested changes Mar 27, 2021

View reviewed changes

Update SCRIPTS.md

9ebc91b

kaustubhgupta suggested changes Mar 28, 2021

View reviewed changes

kaustubhgupta added the minor-change-not-bug Suggested a minor change in code, not a bug label Mar 28, 2021

Update SCRIPTS.md

e8a3559

kaustubhgupta approved these changes Mar 28, 2021

View reviewed changes

kaustubhgupta requested a review from antrikshmisri March 28, 2021 06:00

kaustubhgupta removed the minor-change-not-bug Suggested a minor change in code, not a bug label Mar 28, 2021

antrikshmisri suggested changes Mar 28, 2021

View reviewed changes

Comment thread Battery-Notification/Battery-Notification.py

Update Battery-Notification.py

54daeb9

kaustubhgupta requested a review from antrikshmisri April 7, 2021 05:43

kaustubhgupta added enhancement New feature or request hold Needs a second thought and removed next review needed Approved by some mentors, more approvals needed labels Apr 10, 2021

Update Battery-Notification.py

6b16b1a

kaustubhgupta suggested changes Apr 11, 2021

View reviewed changes

Comment thread Battery-Notification/Battery-Notification.py

kaustubhgupta added bug Something isn't working and removed enhancement New feature or request hold Needs a second thought labels Apr 11, 2021

pankaj892 and others added 2 commits April 11, 2021 12:25

Update Battery-Notification/Battery-Notification.py

0d86656

Co-authored-by: Kaustubh Gupta <kaustubhgupta1828@gmail.com>

Update Battery-Notification.py

5873386

kaustubhgupta approved these changes Apr 12, 2021

View reviewed changes

kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Apr 12, 2021

kaustubhgupta requested review from antrikshmisri and removed request for antrikshmisri April 12, 2021 05:36

kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Apr 14, 2021

avinashkranjan approved these changes Apr 14, 2021

View reviewed changes

avinashkranjan merged commit 4a8bf7b into avinashkranjan:master Apr 14, 2021

		@@ -93,3 +93,4 @@
		\| 89\. \| Voice-Assistant \| Voice-Assistant Bot \| [Take Me](https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/master/Voice-Assistant) \| [Avinash .K. Rajan](https://github.com/avinashkranjan) \|

Uh oh!

Conversation

pankaj892 commented Mar 26, 2021

Description

Fixes #727

Have you read the Contributing Guidelines on Pull Requests?

Type of change

Checklist:

Uh oh!

Uh oh!

santushtisharma10 Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

santushtisharma10 commented Mar 26, 2021

Uh oh!

pankaj892 commented Mar 26, 2021

Uh oh!

santushtisharma10 left a comment

Choose a reason for hiding this comment

Uh oh!

santushtisharma10 commented Mar 27, 2021

Uh oh!

Kushal997-das left a comment

Choose a reason for hiding this comment

Uh oh!

kaustubhgupta Mar 27, 2021

Choose a reason for hiding this comment

Uh oh!

pankaj892 Mar 27, 2021

Choose a reason for hiding this comment

Uh oh!

kaustubhgupta Mar 28, 2021

Choose a reason for hiding this comment

Uh oh!

pankaj892 Mar 28, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

antrikshmisri commented Apr 7, 2021

Uh oh!

pankaj892 commented Apr 8, 2021

Uh oh!

kaustubhgupta commented Apr 8, 2021

Uh oh!

antrikshmisri commented Apr 8, 2021

Uh oh!

kaustubhgupta commented Apr 9, 2021

Uh oh!

pankaj892 commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaustubhgupta commented Apr 10, 2021

Uh oh!

pankaj892 commented Apr 10, 2021

Uh oh!

Uh oh!

pankaj892 commented Apr 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pankaj892 commented Apr 9, 2021 •

edited

Loading