Skip to content

Enhancing Data Visualization Scripts #515#542

Merged
avinashkranjan merged 5 commits into
avinashkranjan:masterfrom
ELITA04:enhance_data_visualization
Mar 14, 2021
Merged

Enhancing Data Visualization Scripts #515#542
avinashkranjan merged 5 commits into
avinashkranjan:masterfrom
ELITA04:enhance_data_visualization

Conversation

@ELITA04
Copy link
Copy Markdown
Contributor

@ELITA04 ELITA04 commented Mar 13, 2021

Description

Used plotly and numpy to randomly generated data with seed. Also saved the images and updated the README.md

Fixes #515

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

github-actions[bot]
github-actions Bot reviewed Mar 13, 2021
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

kaustubhgupta
kaustubhgupta suggested changes Mar 14, 2021
View reviewed changes
Comment thread Data-Visualization/BarChart/bar_chart.py
y = np.random.randint(low = 0, high = 100, size=size)

# creating the Bar Chart
fig = go.Figure(go.Bar(
Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta Mar 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps will make the graph more appealing:

  • add attribute text = y so that values are displayed on the top of bar chart
  • Remove the background grid.
  • Remove the y axis labels and title

Comment thread Data-Visualization/PieChart/pie_chart.py
y = np.random.randint(low = 0, high = 100, size=size)

# creating a Pie Chart
fig = go.Figure(data=[go.Pie(labels=x, values=y)])
Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta Mar 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display the label of sector along with percentage contribution

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Mar 14, 2021
@ELITA04
Copy link
Copy Markdown
Contributor Author

ELITA04 commented Mar 14, 2021

Hi, I made the changes and just wanted to verify if it is correct before pushing the code. Please check and let me know
RevisedBarChart
RevisedPieChart

@kaustubhgupta
Copy link
Copy Markdown
Contributor

kaustubhgupta commented Mar 14, 2021

Hi, I made the changes and just wanted to verify if it is correct before pushing the code. Please check and let me know
RevisedBarChart
RevisedPieChart

Yes, these are perfect. You can push these changes to the PR

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Mar 14, 2021
@kaustubhgupta
Copy link
Copy Markdown
Contributor

kaustubhgupta commented Mar 14, 2021

@antrikshmisri @santushtisharma10 The changes I suggested will be updated by @ELITA04. Other than that if you find any changes kindly convey to @ELITA04

@ELITA04 ELITA04 requested a review from kaustubhgupta March 14, 2021 10:12
kaustubhgupta
kaustubhgupta suggested changes Mar 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ELITA04 delete the previous images for the bar chart and pie chart

@ELITA04 ELITA04 requested a review from kaustubhgupta March 14, 2021 10:31
antrikshmisri
antrikshmisri approved these changes Mar 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@antrikshmisri antrikshmisri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels Mar 14, 2021
@avinashkranjan avinashkranjan merged commit d46c524 into avinashkranjan:master Mar 14, 2021
@avinashkranjan
Copy link
Copy Markdown
Owner

avinashkranjan commented Mar 14, 2021

@all-contributors please add @ELITA04 for code and documentation

@allcontributors allcontributors Bot mentioned this pull request Mar 14, 2021
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Mar 14, 2021

@avinashkranjan

I've put up a pull request to add @ELITA04! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+2 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancing Data Visualization Scripts

4 participants

@ELITA04 @kaustubhgupta @avinashkranjan @antrikshmisri