Action db update by XZANATOL · Pull Request #1025 · avinashkranjan/Amazing-Python-Scripts

XZANATOL · 2021-05-08T12:14:42Z

Description

Added GitHub action files to automatically update JSON database in ./Master Script directory.

Fixes number #831

Didn't correctly link the issue to not auto close it

Have you read the Contributing Guidelines on Pull Requests?

Yes
No

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
Documentation Update

Checklist:

My code follows the style guidelines(Clean Code) of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have created a helpful and easy to understand README.md
My documentation follows Template for README.md
My changes generate no new warnings
I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

XZANATOL · 2021-05-08T12:33:19Z

Why am I feeling nervous? 😂

kaustubhgupta · 2021-05-08T12:38:18Z

Why am I feeling nervous? 😂

nope nope, it's for me to filter out important issue first 😁😁

kaustubhgupta

A couple of changes:

kaustubhgupta · 2021-05-08T12:50:33Z

@@ -36,3 +36,38 @@ _Please delete options that are not relevant._
 - [ ] My documentation follows [`Template for README.md`](https://github.com/avinashkranjan/Amazing-Python-Scripts/blob/master/Template%20for%20README.md)
 - [ ] My changes generate no new warnings
 - [ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.


Add a new check point for this:

I have added the project meta data in the PR template.

kaustubhgupta · 2021-05-08T12:51:21Z

 - [ ] My changes generate no new warnings
 - [ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.


remove these two points

kaustubhgupta · 2021-05-08T12:54:44Z

@@ -14,6 +14,9 @@
 parser = OptionParser()


Rename this file to manual db updater

kaustubhgupta · 2021-05-08T13:21:35Z

@XZANATOL I can't see your new commits. Only the previous 2 commits are visible

XZANATOL · 2021-05-08T13:25:00Z

I didn't make any commits yet, check the comments on the changes you requested.

kaustubhgupta · 2021-05-08T13:30:09Z

I didn't make any commits yet, check the comments on the changes you requested.

there are no comments from your side on those changes

XZANATOL

oh I didn't realize that I should submit the conversations xd my bad

XZANATOL · 2021-05-09T18:30:36Z

Ah right.. after merging the action we can directly test it from my other openned PR #1002 , I've edited it's PR body and after merging you can directly test it out (if I wasn't online at that time.)

kaustubhgupta · 2021-05-10T04:47:07Z

+
+`` If there is no-file/nothing to fill the below fields with, then type: none ``
+
+`` Example: `` If no requirements.txt needed/present then type in ``Requirments`` none => ``Requirments: none``


Umm, I have a question here, According to the regex rule you have in line 10:
requirments_path = r"Requirments: (.+)"

I think it will capture this value irrespective of the case where I am providing a path to file in line 62 in this PR template. This will make every entry in the database none for requirements. I think you can restructure this line as:

Suggested change

`` Example: `` If no requirements.txt needed/present then type in ``Requirments`` none => ``Requirments: none``

`` Example: `` If no requirements.txt needed/present, then type none in ``Requirments``.

Actually there is no need to worry here. I'm using re.match() method not re.search() to get the contents. re.match() will match the whole string not search inside of it.. it's like ==

Yes, I realized this after running through multiple test

kaustubhgupta · 2021-05-10T12:17:58Z

+    print("[+] PyGithub Login Success!")
+    repo = git.get_repo("avinashkranjan/Amazing-Python-Scripts")
+    datastore_file = repo.get_contents("./Master Script/datastore.json")
+    repo.update_file(datastore_file.path, "Updated datastore.json", data_store, datastore_file.sha, branch="main")


A major error:

Suggested change

repo.update_file(datastore_file.path, "Updated datastore.json", data_store, datastore_file.sha, branch="main")

repo.update_file(datastore_file.path, "Updated datastore.json", data_store, datastore_file.sha, branch="master")

Oh.. my bad on that one.. I always get confused between them. xd

No issues, I have fixed this

kaustubhgupta · 2021-05-10T12:25:36Z

Also, check out this log:

https://github.com/kaustubhgupta/gitpractise/runs/2545434245?check_suite_focus=true

The file is not being pushed to the gh-pages branch as the sha values are not matching for both branches. I think you need to get the contents of the master branch and gh-pages branch separately and then use the .update_file method to push the files

Did all the necessay changes

kaustubhgupta · 2021-05-10T13:24:19Z

@XZANATOL Never mind, I have handled these errors and committed the same.

XZANATOL · 2021-05-10T13:26:41Z

Hi, have just got home.. xd
Lemme take a look at the requested

kaustubhgupta · 2021-05-10T13:33:39Z

@XZANATOL Finally the script worked successfully on this repo: https://github.com/kaustubhgupta/gitpractise

After 12 PRs xd

XZANATOL · 2021-05-10T13:41:52Z

I think this is the hardest challenge I've ever faced. tho it was fun! xD

avinashkranjan

LGTM..Great Work Guys @XZANATOL & @kaustubhgupta

XZANATOL · 2021-05-10T20:48:38Z

@kaustubhgupta just before forgetting, can you add GSSOC labels? xd + test the action in #1002

kaustubhgupta · 2021-05-11T03:05:49Z

@kaustubhgupta just before forgetting, can you add GSSOC labels? xd + test the action in #1002

Done ✅

XZANATOL added 2 commits May 8, 2021 14:05

added github action files & updated database

8bb054e

added python script used by github actions

03caee2

kaustubhgupta added the Urgent Issues needed to be address Immediately label May 8, 2021

kaustubhgupta self-requested a review May 8, 2021 12:37

kaustubhgupta suggested changes May 8, 2021

View reviewed changes

Comment thread .github/scripts/Update_Database.py

kaustubhgupta reviewed May 8, 2021

View reviewed changes

Comment thread .github/workflows/database_auto_updater.yml

XZANATOL requested a review from kaustubhgupta May 8, 2021 13:17

XZANATOL commented May 8, 2021

View reviewed changes

Comment thread .github/pull_request_template.md Outdated

Comment thread .github/pull_request_template.md Outdated

Comment thread .github/pull_request_template.md Outdated

Comment thread .github/scripts/Update_Database.py

Comment thread .github/workflows/database_auto_updater.yml

Added requested changes

3853466

kaustubhgupta suggested changes May 9, 2021

View reviewed changes

Added requested changes v2

8265e23

XZANATOL requested a review from kaustubhgupta May 9, 2021 18:27

kaustubhgupta suggested changes May 10, 2021

View reviewed changes

kaustubhgupta added the bug Something isn't working label May 10, 2021

Changes

f6498f0

Did all the necessay changes

kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels May 10, 2021

kaustubhgupta approved these changes May 10, 2021

View reviewed changes

kaustubhgupta requested a review from avinashkranjan May 10, 2021 13:27

kaustubhgupta requested review from antrikshmisri and santushtisharma10 May 10, 2021 13:27

avinashkranjan approved these changes May 10, 2021

View reviewed changes

antrikshmisri approved these changes May 10, 2021

View reviewed changes

avinashkranjan merged commit fe77510 into avinashkranjan:master May 10, 2021

kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels May 11, 2021

kaustubhgupta mentioned this pull request May 11, 2021

Making the Whole Project/Repo Menu-Driven #831

Open

		- [ ] My changes generate no new warnings
		- [ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.


		`` If there is no-file/nothing to fill the below fields with, then type: none ``

		`` Example: `` If no requirements.txt needed/present then type in ``Requirments`` none => ``Requirments: none``

	repo.update_file(datastore_file.path, "Updated datastore.json", data_store, datastore_file.sha, branch="main")
	repo.update_file(datastore_file.path, "Updated datastore.json", data_store, datastore_file.sha, branch="master")

Uh oh!

Conversation

XZANATOL commented May 8, 2021

Description

Fixes number #831

Have you read the Contributing Guidelines on Pull Requests?

Type of change

Checklist:

Uh oh!

XZANATOL commented May 8, 2021

Uh oh!

kaustubhgupta commented May 8, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaustubhgupta commented May 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XZANATOL commented May 8, 2021

Uh oh!

kaustubhgupta commented May 8, 2021

Uh oh!

XZANATOL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XZANATOL commented May 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaustubhgupta commented May 10, 2021

Uh oh!

kaustubhgupta commented May 10, 2021

Uh oh!

XZANATOL commented May 10, 2021

Uh oh!

kaustubhgupta commented May 10, 2021

Uh oh!

XZANATOL commented May 10, 2021

Uh oh!

avinashkranjan left a comment

Choose a reason for hiding this comment

Uh oh!

XZANATOL commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

kaustubhgupta commented May 8, 2021 •

edited

Loading

XZANATOL commented May 9, 2021 •

edited

Loading

XZANATOL commented May 10, 2021 •

edited

Loading