Skip to content

Landing page ui #129

Merged
pkrawat1 merged 9 commits into
developfrom
landing_page
May 16, 2018
Merged

Landing page ui #129
pkrawat1 merged 9 commits into
developfrom
landing_page

Conversation

@jaypal412
Copy link
Copy Markdown
Contributor

@jaypal412 jaypal412 commented May 11, 2018

Work on the landing page
Work on responsive for landing page
work on footer with responsive
work on header

fixes #157474908, #157585614, #157585605

@jaypal412 jaypal412 self-assigned this May 11, 2018
@jaypal412 jaypal412 requested a review from pkrawat1 May 11, 2018 13:50
@pkrawat1 pkrawat1 added WIP work in progress do not merge labels May 14, 2018
@jaypal412 jaypal412 removed WIP work in progress do not merge labels May 16, 2018
border-color: $black - 200;
}
}
/deep/.product-tile p{ margin-bottom:0px;white-space: normal;margin-top:10px;}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation is missing

padding:0rem;
color:#fff;
}
.backtopbtn { background-color:#a3d032 - 40;border-radius: 4px;text-decoration: none; padding: 0.7rem 1.8rem;}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation missing.

Comment thread src/app/app.module.ts Outdated
imports: [
RouterModule.forRoot(routes, { preloadingStrategy: PreloadAllModules }),
StoreModule.forRoot(reducers, { metaReducers }),
StoreModule.forRoot(reducers, { metaReducers }), BrowserAnimationsModule,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here


@media screen and(min-width: 320px) and(max-width: 768px){
.contact-info{
a{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here

padding: 10px;
}
ul{list-style: none}
$break-small: 320px;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here

}
.social-link {
text-align: right
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here

.quicklinks .row {
margin: 0px
}
.cpy1 {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here

@@ -0,0 +1,4 @@
a,a:focus{color:#000;text-decoration: None;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@@ -0,0 +1,2 @@
.sucathead{color:#000;text-decoration: underline;font-size: 14px; }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation here

Copy link
Copy Markdown
Member

@pkrawat1 pkrawat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkrawat1 pkrawat1 merged commit 6494937 into develop May 16, 2018
@pkrawat1 pkrawat1 deleted the landing_page branch May 16, 2018 07:19
pkrawat1 pushed a commit that referenced this pull request Jun 13, 2018
* work on the landing page Ui

* work on the footer and landing page

* Work on the heaadr menu

* Work on the login page

* Work on the login page

* Hiding animation

* Work on indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants