Favorite products#100
Merged
Merged
Conversation
Member
chandradot99
commented
Apr 24, 2018
- mark a product as favorite from the product page.
- It gives user the ability to see all products marked as favorite by him/her
- Admin can view which products have been marked as favorite, and by which users, on the Admin end.
pkrawat1
requested changes
Apr 25, 2018
Member
There was a problem hiding this comment.
add return types for http methods here too markAsFavorite(id: number): <Return Type> { return this.http.post(/spree/favorite_products, {id: id}) }`
Member
There was a problem hiding this comment.
please use bootstrap classes only here for modularity purposes.
Member
There was a problem hiding this comment.
Can we use a default value here as an empty array. So that we don't do length check here.
Just *ngIf="products$ | async; let products; else elseBlock" would be enough.
Member
Author
There was a problem hiding this comment.
@pkrawat1 if we use this, then empty array would always return true and else block will never run.
Member
There was a problem hiding this comment.
<div *ngIf="products$ | async; let products">
<table class="table" *ngIf="products.length; else elseBlock">
<thead class="thead-light">
<tr>
<th scope="col">Product Image</th>
<th scope="col">Product Name</th>
<th scope="col">Action</th>
</tr>
</thead>
<tbody>
<app-favorite-product-list-item *ngFor="let product of products" [product]="product"></app-favorite-product-list-item>
</tbody>
</table>
<ng-template #elseBlock>
<div>You have'nt favorited anything yet.</div>
</ng-template>
</div>
Member
There was a problem hiding this comment.
why async twice 🤨 here. use *ngIf="products$ | async; let products; else elseBlock"
Member
There was a problem hiding this comment.
indentation or autocorrect please
802df1f to
465ee54
Compare
pkrawat1
requested changes
Apr 25, 2018
Member
There was a problem hiding this comment.
<div *ngIf="products$ | async; let products">
<table class="table" *ngIf="products.length; else elseBlock">
<thead class="thead-light">
<tr>
<th scope="col">Product Image</th>
<th scope="col">Product Name</th>
<th scope="col">Action</th>
</tr>
</thead>
<tbody>
<app-favorite-product-list-item *ngFor="let product of products" [product]="product"></app-favorite-product-list-item>
</tbody>
</table>
<ng-template #elseBlock>
<div>You have'nt favorited anything yet.</div>
</ng-template>
</div>add favorite product functionality remove from favorite functionality remove unmark as favorite option from product detail page indentation and bug fixes use async pipe in view only once
465ee54 to
29b3557
Compare
pkrawat1
approved these changes
Apr 25, 2018
pkrawat1
pushed a commit
that referenced
this pull request
Jun 13, 2018
add favorite product functionality remove from favorite functionality remove unmark as favorite option from product detail page indentation and bug fixes use async pipe in view only once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.