Skip to content

feat: add reset button to entry details#239

Open
Hamedamz wants to merge 1 commit intoauthpass:mainfrom
arshiamoghimi:feat-entry-reset-button
Open

feat: add reset button to entry details#239
Hamedamz wants to merge 1 commit intoauthpass:mainfrom
arshiamoghimi:feat-entry-reset-button

Conversation

@Hamedamz
Copy link
Copy Markdown

It adds a reset button (LinkButton) before save button in the entry details view.
Fixes #91

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 15, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Collaborator

@hpoul hpoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR.
unfortunately i don't think this will work correctly. This will only reset the values in the form fields to those in the kdbx models. But those are changed for example for passwords on every blur.. or when adding/removing fields..
I have to admit this is not really a clean implementation to begin with, because some state is only written "onSave" while others immediately triggered by other actions (changing entry structure, attaching files, etc.).

I think it would be easier to have a file-level "reset" where i can revert all changes in a file.. basically a close and reopen of the whole file.. 🤔️ (maybe more of a 'reset' button in the app bar next to the 'save' icon when the file is dirty)
The file shouldn't be "dirty" after changes have been reverted..

@hpoul hpoul force-pushed the master branch 5 times, most recently from 07309c0 to be49e16 Compare August 5, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve/Implement entry "revert changes"

3 participants