feat: add dynamic module loading for client imports#871
Open
GunniBusch wants to merge 1 commit intoauthlib:mainfrom
Open
feat: add dynamic module loading for client imports#871GunniBusch wants to merge 1 commit intoauthlib:mainfrom
GunniBusch wants to merge 1 commit intoauthlib:mainfrom
Conversation
Author
|
The tests are failing due to a lower test coverage. But it doesn’t make sense to test a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a bugfix for developer ergonomics/import discovery.
It adds lazy-exported integration submodules in
authlib.integrations.__init__(includingstarlette_client) so IDEs/type checkers can resolveauthlib.integrations.starlette_clientcorrectly without forcing eager imports of optional integrations.Related issue/PR: N/A.
Does this PR introduce a breaking change?
No.
Checklist
prek.pragma: no coverThis pull request refactors the
authlib/integrations/__init__.pyfile to implement lazy loading for its submodules. This approach optimizes import times and resource usage by only loading submodules when they are actually accessed.Key changes:
Lazy Loading Implementation:
__getattr__function that usesimportlib.import_moduleto dynamically import submodules listed in__all__when accessed as attributes. This enables lazy loading of integration submodules.Type Checking Support:
TYPE_CHECKINGblock to ensure that type checkers are aware of the available submodules without triggering actual imports at runtime.Module Export Definition:
__all__list to specify the public submodules available for import from theauthlib.integrationspackage.