Skip to content

Commit a353a59

Browse files
code-asherkylecarbs
authored andcommitted
Move wheel event change out of patch
1 parent b407228 commit a353a59

2 files changed

Lines changed: 11 additions & 26 deletions

File tree

packages/vscode/src/fill/dom.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import * as dom from "vs/base/browser/dom";
2+
import { IDisposable } from "vs/base/common/lifecycle";
3+
14
// Firefox has no implementation of toElement.
25
if (!("toElement" in MouseEvent.prototype)) {
36
Object.defineProperty(MouseEvent.prototype, "toElement", {
@@ -17,3 +20,11 @@ if (!("toElement" in MouseEvent.prototype)) {
1720
},
1821
});
1922
}
23+
24+
const _addDisposableListener = dom.addDisposableListener;
25+
const addDisposableListener = (node: Element | Window | Document, type: string, handler: (event: any) => void, useCapture?: boolean): IDisposable => {
26+
return _addDisposableListener(node, type === "mousewheel" ? "wheel" : type, handler, useCapture);
27+
};
28+
29+
const target = dom as typeof dom;
30+
target.addDisposableListener = addDisposableListener;

scripts/vscode.patch

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,3 @@
1-
diff --git a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
2-
index a6256deeba..69819e0f3a 100644
3-
--- a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
4-
+++ b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
5-
@@ -311,7 +311,7 @@ export abstract class AbstractScrollableElement extends Widget {
6-
this._onMouseWheel(new StandardWheelEvent(browserEvent));
7-
};
8-
9-
- this._mouseWheelToDispose.push(dom.addDisposableListener(this._listenOnDomNode, 'mousewheel', onMouseWheel));
10-
+ this._mouseWheelToDispose.push(dom.addDisposableListener(this._listenOnDomNode, 'wheel', onMouseWheel));
11-
}
12-
}
13-
141
diff --git a/src/vs/code/electron-browser/sharedProcess/sharedProcessMain.ts b/src/vs/code/electron-browser/sharedProcess/sharedProcessMain.ts
152
index 457818a975..ad45ffe58a 100644
163
--- a/src/vs/code/electron-browser/sharedProcess/sharedProcessMain.ts
@@ -21,19 +8,6 @@ index 457818a975..ad45ffe58a 100644
218
}
229
+
2310
+startup({ machineId: "1" });
24-
diff --git a/src/vs/editor/browser/controller/mouseHandler.ts b/src/vs/editor/browser/controller/mouseHandler.ts
25-
index 1a8af35373..ae45e08aeb 100644
26-
--- a/src/vs/editor/browser/controller/mouseHandler.ts
27-
+++ b/src/vs/editor/browser/controller/mouseHandler.ts
28-
@@ -121,7 +121,7 @@ export class MouseHandler extends ViewEventHandler {
29-
e.stopPropagation();
30-
}
31-
};
32-
- this._register(dom.addDisposableListener(this.viewHelper.viewDomNode, 'mousewheel', onMouseWheel, true));
33-
+ this._register(dom.addDisposableListener(this.viewHelper.viewDomNode, 'wheel', onMouseWheel, true));
34-
35-
this._context.addEventHandler(this);
36-
}
3711
diff --git a/src/vs/editor/contrib/clipboard/clipboard.ts b/src/vs/editor/contrib/clipboard/clipboard.ts
3812
index 5e43f1b39e..7775e3b6da 100644
3913
--- a/src/vs/editor/contrib/clipboard/clipboard.ts

0 commit comments

Comments
 (0)