Skip to content

Commit b407228

Browse files
code-asherkylecarbs
authored andcommitted
Move mouse wheel fix out of patch
1 parent d677a2e commit b407228

3 files changed

Lines changed: 20 additions & 29 deletions

File tree

packages/vscode/src/client.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import "./fill/windowsService";
66
import "./fill/environmentService";
77
import "./fill/vscodeTextmate";
88
import "./fill/codeEditor";
9+
import "./fill/mouseEvent";
910
import { PasteAction } from "./fill/paste";
1011
import "./fill/dom";
1112
import "./vscode.scss";
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import * as mouse from "vs/base/browser/mouseEvent";
2+
3+
/**
4+
* Fix the wheel event for Firefox.
5+
*/
6+
class StandardWheelEvent extends mouse.StandardWheelEvent {
7+
8+
public constructor(event: mouse.IMouseWheelEvent | null) {
9+
super(
10+
event,
11+
(-(event as any as MouseWheelEvent).deltaX || 0) / 3, // tslint:disable-line no-any
12+
(-(event as any as MouseWheelEvent).deltaY || 0) / 3, // tslint:disable-line no-any
13+
);
14+
}
15+
16+
}
17+
18+
const target = mouse as typeof mouse;
19+
target.StandardWheelEvent = StandardWheelEvent;

scripts/vscode.patch

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,3 @@
1-
diff --git a/src/vs/base/browser/mouseEvent.ts b/src/vs/base/browser/mouseEvent.ts
2-
index 89ff65ec49..bc0cf2b08c 100644
3-
--- a/src/vs/base/browser/mouseEvent.ts
4-
+++ b/src/vs/base/browser/mouseEvent.ts
5-
@@ -147,12 +147,15 @@ export class StandardWheelEvent {
6-
if (e) {
7-
let e1 = <IWebKitMouseWheelEvent><any>e;
8-
let e2 = <IGeckoMouseWheelEvent><any>e;
9-
+ let e3 = <MouseWheelEvent><any>e;
10-
11-
// vertical delta scroll
12-
if (typeof e1.wheelDeltaY !== 'undefined') {
13-
this.deltaY = e1.wheelDeltaY / 120;
14-
} else if (typeof e2.VERTICAL_AXIS !== 'undefined' && e2.axis === e2.VERTICAL_AXIS) {
15-
this.deltaY = -e2.detail / 3;
16-
+ } else if (typeof e3.deltaY !== "undefined") {
17-
+ this.deltaY = -e3.deltaY / 3;
18-
}
19-
20-
// horizontal delta scroll
21-
@@ -164,6 +167,8 @@ export class StandardWheelEvent {
22-
}
23-
} else if (typeof e2.HORIZONTAL_AXIS !== 'undefined' && e2.axis === e2.HORIZONTAL_AXIS) {
24-
this.deltaX = -e.detail / 3;
25-
+ } else if (typeof e3.deltaX !== "undefined") {
26-
+ this.deltaX = -e3.deltaX / 3;
27-
}
28-
29-
// Assume a vertical scroll if nothing else worked
301
diff --git a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts
312
index a6256deeba..69819e0f3a 100644
323
--- a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts

0 commit comments

Comments
 (0)