Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Highlight comments in module - #246

Merged
sadikovi merged 1 commit into
atom:masterfrom
Eskibear:module-comment
Jan 23, 2021
Merged

Highlight comments in module#246
sadikovi merged 1 commit into
atom:masterfrom
Eskibear:module-comment

Conversation

@Eskibear

Copy link
Copy Markdown
Contributor

Signed-off-by: Yan Zhang yanzh@microsoft.com

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

To enable comments and javadocs in module

Alternate Designs

unknown

Benefits

To fix part of #245

Possible Drawbacks

unknown

Applicable Issues

#245

@sadikovi sadikovi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few comments, would appreciate it if you could take a look. I can merge the PR afterwards.

Comment thread spec/java-spec.coffee Outdated
Comment thread spec/java-spec.coffee Outdated
Comment thread grammars/java.cson
Comment thread spec/java-spec.coffee Outdated
@sadikovi sadikovi changed the title highlight comments in module Highlight comments in module Jan 21, 2021
@sadikovi
sadikovi merged commit 29f977d into atom:master Jan 23, 2021
@sadikovi

Copy link
Copy Markdown
Contributor

Thank you for fixing it! Merged to master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants