Skip to content

Consolidate Parameter Handling#19989

Open
WilliamJamieson wants to merge 1 commit into
astropy:mainfrom
WilliamJamieson:consolidate_parameter
Open

Consolidate Parameter Handling#19989
WilliamJamieson wants to merge 1 commit into
astropy:mainfrom
WilliamJamieson:consolidate_parameter

Conversation

@WilliamJamieson

Copy link
Copy Markdown
Contributor

Description

This pull request consolidates much of the parameter value setting functions into the parameter object instead of having the model externally manipulate private variables inside the parameter.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

… to helper functions built into the parameter
@WilliamJamieson WilliamJamieson force-pushed the consolidate_parameter branch from efa9482 to 5950a46 Compare June 25, 2026 17:30
@WilliamJamieson WilliamJamieson marked this pull request as ready for review June 25, 2026 17:31
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner June 25, 2026 17:31
@WilliamJamieson WilliamJamieson requested a review from pllim June 25, 2026 17:31
@WilliamJamieson WilliamJamieson added this to the v8.1.0 milestone Jun 25, 2026
@pllim

pllim commented Jun 25, 2026

Copy link
Copy Markdown
Member

I won't have enough expertise to review the internals touched here. Are either @perrygreenfield or @nden able to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants