Skip to content

WHL: drop win32 support (stop distributing wheels)#19931

Open
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:whl/drop-win32
Open

WHL: drop win32 support (stop distributing wheels)#19931
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:whl/drop-win32

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Following numpy
https://mail.python.org/archives/list/numpy-discussion@python.org/thread/FGVCDS5JICVIUVBISGWZNQ46QZ3XX5PB/#TTSOQQ3XLXXK52CZYMN7MALJQEI65UDN

I don't think this needs backporting, but does it need a changelog entry ? as noted in the thread, demand for these wheels is very low and getting lower.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone Jun 17, 2026
@neutrinoceros neutrinoceros added Windows Build all wheels Run all the wheel builds rather than just a selection labels Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Jun 17, 2026

Copy link
Copy Markdown
Member

But it is not broken yet.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Does that mean we should keep publishing wheels nobody needs until our oldest supported numpy is >=2.6 ?

@pllim

pllim commented Jun 17, 2026

Copy link
Copy Markdown
Member

nobody needs

We don't know that. There is always one user somewhere that somehow still needs it.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

well, numpy, scipy, pandas, matplotlib (to name a few) have already dropped it, so I have serious doubts that our users are numerous enough to justify keeping these.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Also, I'm proposing this only for 8.1+, and if anyone still relies on astropy upgrades for this platform:

  • they'll still get the 8.0.x series
  • after that, they can probably still build from source
  • conda-forge users might still get further updates (although I suspect conda-forge itself won't be supporting it much longer)

@astrofrog

Copy link
Copy Markdown
Member

Given that even numpy are dropping it and other projects already have, I think we should probably just drop it so my vote is +1

@neutrinoceros

neutrinoceros commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

We don't know that. There is always one user somewhere that somehow still needs it.

I just queried the download data from the last week, limited to the 1000 most downloaded artifacts over this period, using https://github.com/ofek/pypinfo

here's the relevant subset

| 6.1.7       | astropy-6.1.7-cp310-cp310-win32.whl.metadata                                                                                | Windows     |             44 |
| 6.1.7       | astropy-6.1.7-cp310-cp310-win32.whl                                                                                         | Windows     |             44 |
| 6.0.1       | astropy-6.0.1-cp39-cp39-win32.whl                                                                                           | Windows     |              8 |
| 6.0.1       | astropy-6.0.1-cp39-cp39-win32.whl.metadata                                                                                  | Windows     |              6 |
| 5.0         | astropy-5.0-cp39-cp39-win32.whl                                                                                             | Windows     |              6 |
| 5.0         | astropy-5.0-cp39-cp39-win32.whl.metadata                                                                                    | Windows     |              6 |
| 7.2.0       | astropy-7.2.0-cp311-abi3-win32.whl.metadata                                                                                 | Windows     |              4 |
| 5.2.2       | astropy-5.2.2-cp38-cp38-win32.whl                                                                                           | Windows     |              2 |
| 5.2.2       | astropy-5.2.2-cp38-cp38-win32.whl.metadata                                                                                  | Windows     |              1 |
| 4.1         | astropy-4.1-cp38-cp38-win32.whl                                                                                             | Windows     |              1 |
| 4.1         | astropy-4.1-cp38-cp38-win32.whl.metadata                                                                                    | Windows     |              1 |

(this is out of 514,362 downloads, combining our 1000 most popular artifacts)

This represents about 0.2% of downloads, and 96% of these are for Python versions we dropped almost 2 years ago at the latest.

@pllim

pllim commented Jun 18, 2026

Copy link
Copy Markdown
Member
| 7.2.0       | astropy-7.2.0-cp311-abi3-win32.whl.metadata    | Windows     |              4 |

That is 3 more than what I predicted. 😆

Well, if I am outvoted, then I shall 🤐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build all wheels Run all the wheel builds rather than just a selection Release Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants