DEP: avoid direct dependency on html5lib as an implementation detail from pandas#19900
Open
neutrinoceros wants to merge 1 commit into
Open
DEP: avoid direct dependency on html5lib as an implementation detail from pandas#19900neutrinoceros wants to merge 1 commit into
neutrinoceros wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
e93e2fc to
1c90206
Compare
1c90206 to
1d71e6f
Compare
neutrinoceros
commented
Jun 11, 2026
Comment on lines
-45
to
-51
| # Special case: pandas defaults to HTML lxml for reading, but does not attempt | ||
| # to fall back to bs4 + html5lib. So do that now for convenience if user has | ||
| # not specifically selected a flavor. If things go wrong the pandas exception | ||
| # with instruction to install a library will come up. | ||
| if pandas_fmt == "html" and "flavor" not in kwargs: | ||
| if not HAS_LXML and HAS_HTML5LIB and HAS_BS4: | ||
| read_kwargs["flavor"] = "bs4" |
Contributor
Author
There was a problem hiding this comment.
As it turns out, this hack is actually obsolete with pandas>=2.2 (and we don't support older versions):
The default of
Nonetries to uselxmlto parse and if that fails it falls back onbs4+html5lib.
source:
https://pandas.pydata.org/pandas-docs/version/2.2/reference/api/pandas.read_html.html
mhvk
approved these changes
Jun 15, 2026
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Yes, seems nice to make the dependency implicit! Comment in-line is minor, so approving, but might be good to get some further opinion.
| ipython = [ | ||
| "ipython>=8.1.0", | ||
| ] | ||
| pandas = [ |
Contributor
There was a problem hiding this comment.
I slightly wonder why make an explicit option astropy[pandas] rather than just list pandas[html]>=2.2.2 where needed. Is it so that users can do it too?
Contributor
Author
There was a problem hiding this comment.
It's for deduplication of the lower boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ref #14316