Skip to content

TST: fine tune per-index cooldown periods#19886

Open
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:mnt/per-index-cooldowns
Open

TST: fine tune per-index cooldown periods#19886
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:mnt/per-index-cooldowns

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Follow up to #19527
Instead of whitelisting certain packages as I initially imagined, make move the trust to the sp-python nightlies channel itself.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Ah, this doesn't quite work as I thought. Configuring an index implies it's always included in resolution, which isn't what we want.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

This is now working as intended, with an extremely minor defect: it h5py's nightlies are currently preferred to stable releases. And that's just because it doesn't use dev version numbers (yet). All other nightly packages behave as you'd expect, so even with indexes permanently configured, we only get nightlies when preleases are enabled.

@neutrinoceros neutrinoceros force-pushed the mnt/per-index-cooldowns branch from 4dce841 to b67d9f9 Compare June 10, 2026 06:33
@neutrinoceros neutrinoceros marked this pull request as ready for review June 10, 2026 06:33
@neutrinoceros neutrinoceros force-pushed the mnt/per-index-cooldowns branch from b67d9f9 to 25e2f6c Compare June 10, 2026 06:35
@neutrinoceros neutrinoceros force-pushed the mnt/per-index-cooldowns branch from 25e2f6c to 0e0a0a2 Compare June 10, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant