Skip to content

BUG: fix a regression in minversion where minversion(erfa) would crash on pyinstaller#19818

Merged
pllim merged 2 commits into
astropy:mainfrom
neutrinoceros:tst/portable-minversion-erfa
May 28, 2026
Merged

BUG: fix a regression in minversion where minversion(erfa) would crash on pyinstaller#19818
pllim merged 2 commits into
astropy:mainfrom
neutrinoceros:tst/portable-minversion-erfa

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented May 28, 2026

Description

Fixes a subtle regression caused by #19598, merged yesterday, and which showed up on today's daily cron job

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone May 28, 2026
@neutrinoceros neutrinoceros added Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed Extra CI Run cron CI as part of PR labels May 28, 2026
@github-actions github-actions Bot added the utils label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Should have run Extra CI on that original PR, I guess. Thanks for the fix.

Does the original change log content need updating as well?

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

I mean it's much easier to see that it was needed now. IMO it's fine that we only found out the day after, that's still pretty soon in the dev cycle !
changelog updated

@pllim pllim added skip-changelog-checks Tells bot to skip changlog checks and removed no-changelog-entry-needed labels May 28, 2026
@pllim pllim merged commit 6aab4b0 into astropy:main May 28, 2026
47 of 61 checks passed
@neutrinoceros neutrinoceros deleted the tst/portable-minversion-erfa branch May 28, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug Extra CI Run cron CI as part of PR skip-changelog-checks Tells bot to skip changlog checks utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants