Change np.rollaxis to np.moveaxis to fix issue #15721#19781
Open
thiagodcoq wants to merge 3 commits into
Open
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
larrybradley
approved these changes
May 20, 2026
Member
larrybradley
left a comment
There was a problem hiding this comment.
I'm approving for stats only (test_sigma_clipping.py).
Member
|
Something is wrong with the CI though. |
pllim
reviewed
May 20, 2026
Author
|
Sorry about the accidental file! That was just a Copilot summary I generated to help me understand the use cases for the functions I was changing. I've just removed and will push the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I replaced calls to np.rollaxis with np.moveaxis, using a conversion table I created to guide the refactoring. The difference between those functions is that while rollaxis rolls a given axis into a specified position, moveaxis works more like a cut and insertion.

This pull request is to address ...
Fixes #15721