Skip to content

Change np.rollaxis to np.moveaxis to fix issue #15721#19781

Open
thiagodcoq wants to merge 3 commits into
astropy:mainfrom
thiagodcoq:fix-issue-15721
Open

Change np.rollaxis to np.moveaxis to fix issue #15721#19781
thiagodcoq wants to merge 3 commits into
astropy:mainfrom
thiagodcoq:fix-issue-15721

Conversation

@thiagodcoq
Copy link
Copy Markdown

@thiagodcoq thiagodcoq commented May 20, 2026

Description

I replaced calls to np.rollaxis with np.moveaxis, using a conversion table I created to guide the refactoring. The difference between those functions is that while rollaxis rolls a given axis into a specified position, moveaxis works more like a cut and insertion.
image

This pull request is to address ...

Fixes #15721

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v8.1.0 milestone May 20, 2026
Copy link
Copy Markdown
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving for stats only (test_sigma_clipping.py).

@pllim
Copy link
Copy Markdown
Member

pllim commented May 20, 2026

Something is wrong with the CI though.

Comment thread IERS_EXPLORATION_SUMMARY.md Outdated
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fishy.

@thiagodcoq
Copy link
Copy Markdown
Author

thiagodcoq commented May 20, 2026

Sorry about the accidental file! That was just a Copilot summary I generated to help me understand the use cases for the functions I was changing. I've just removed and will push the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace np.rollaxis() with np.moveaxis() but it is not drop-in replacement

3 participants