Remove deprecated introspection.isinstancemethod() and introspection.find_mod_objs()#19770
Draft
jomigmonte wants to merge 4 commits into
Draft
Remove deprecated introspection.isinstancemethod() and introspection.find_mod_objs()#19770jomigmonte wants to merge 4 commits into
jomigmonte wants to merge 4 commits into
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
Thanks! Looks good at a glance but will have to re-review again when the time comes when we can actually merge this. Will just have to let this sit for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the removal of the deprecated methods introspection.isinstancemethod() and introspection.find_mod_objs(), along with their respective tests.
Fixes #15936