Skip to content

WHL/EXP: check cibuilwheel 4.0.0rc1#19756

Draft
neutrinoceros wants to merge 2 commits into
astropy:mainfrom
neutrinoceros:whl/cibw4
Draft

WHL/EXP: check cibuilwheel 4.0.0rc1#19756
neutrinoceros wants to merge 2 commits into
astropy:mainfrom
neutrinoceros:whl/cibw4

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented May 17, 2026

Description

Starting this as an experiment to see whether the upgrade is uneventful for us.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone May 17, 2026
@neutrinoceros neutrinoceros added build dev-automation Build all wheels Run all the wheel builds rather than just a selection dependencies Pull requests that update a dependency file labels May 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

neutrinoceros commented May 17, 2026

Builds are still succeeding despite this wall of red. What changed is that cibuildwheel now automatically detect and audits abi3 wheels via abi3audit, which we haven't done before, and it looks like we have a bunch of ABI violations right now. Probably nothing major (I hope), but I'll dig further into this in the following week.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

neutrinoceros commented May 20, 2026

The fix is large but trivial. I'm keeping it here for illustration, but it's also split into #19774

neutrinoceros
neutrinoceros commented May 20, 2026
View reviewed changes
Comment thread pyproject.toml Outdated
skip = ["cp*t-*"] # https://github.com/astropy/astropy/issues/16916
skip = [
"cp*t-*", # https://github.com/astropy/astropy/issues/16916
"cp315-win_*",
Copy link
Copy Markdown
Contributor Author

@neutrinoceros neutrinoceros May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping this target for now because of what looks like segmentation faults on windows. I don't know yet if they are from us, numpy or Python 3.15, but the latter seems most likely, and there are still 3 betas and 2 rcs to go before it's final, which seems enough to be a bit optimistic. I'll report upstream if the problem persists with the second beta.

@neutrinoceros neutrinoceros force-pushed the whl/cibw4 branch 4 times, most recently from 8a0d49f to 9d63fd3 Compare May 22, 2026 06:59
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

neutrinoceros commented Jun 4, 2026 •
edited
Loading

3.15.0b2 still hits a segfault on win_amd64.
update: cibuildwheel is actually still on 3.15.0b1, I cannot test 3.15.0b2 yet

I'll try to understand where it's coming from before I report upstream, but I'm still think CPython is my first suspect.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

neutrinoceros commented Jun 4, 2026

numpy/numpy#31564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport-v8.0.x on-merge: backport to v8.0.x Build all wheels Run all the wheel builds rather than just a selection build dependencies Pull requests that update a dependency file dev-automation no-changelog-entry-needed Python 3.15 Release testing

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@neutrinoceros