ENH: Add separation_projected method for projected separation #19739
Open
saanikakulkarni07 wants to merge 4 commits into
Open
ENH: Add separation_projected method for projected separation #19739saanikakulkarni07 wants to merge 4 commits into
saanikakulkarni07 wants to merge 4 commits into
Conversation
…tions Adds separation_projected() to BaseCoordinateFrame for computing on-sky separation projected along a position angle axis, with optional elliptical distance weighting. Closes astropy#1012.
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds separation_projected() to BaseCoordinateFrame for computing on-sky
separation projected along a position angle axis, with optional elliptical
distance weighting. Closes #1012.
Description
This pull request adds a
separation_projected()method toBaseCoordinateFrame(automatically available onSkyCoord) that decomposes the angular separation between two coordinates into components parallel and perpendicular to a referenceposition angle.
This is a common operation in galaxy and jet studies — measuring the distance to an object projected along a specific axis (e.g., a galaxy's major axis). Currently
separation()only gives the total angular distance.API:
pa— reference position angle (East from North)return_components=True— return signed(d_parallel, d_perpendicular)tupleb_over_a— elliptical distance with minor/major axis ratioorigin_mismatch— consistent withseparation()Includes:
astropy/coordinates/baseframe.pytest_separation.py(all pass, no regressions in existing 140 tests)docs/changes/coordinates/1012.feature.rstFixes #1012