DataOrigin1.2 backward compatibility#19678
Open
gilleslandais wants to merge 3 commits into
Open
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Member
|
Thank you! |
bsipocz
requested changes
May 6, 2026
Member
bsipocz
left a comment
There was a problem hiding this comment.
@gilleslandais unfortunately this doesn't do what it's supposed to do; the previous code should run, but have deprecation warnings.
We already have those deprecations in place, so we just need to make sure to use rather than override them.
1832440 to
0fba23c
Compare
Contributor
Author
|
I hope it isok now (it was a bad usage of |
Member
|
@bsipocz does this look good to you now? We need to ship beta soon. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a direct follow-up for #19593
Fixes #19663