Skip to content

DataOrigin1.2 backward compatibility#19678

Open
gilleslandais wants to merge 3 commits into
astropy:mainfrom
gilleslandais:dataorigin1.2
Open

DataOrigin1.2 backward compatibility#19678
gilleslandais wants to merge 3 commits into
astropy:mainfrom
gilleslandais:dataorigin1.2

Conversation

@gilleslandais
Copy link
Copy Markdown
Contributor

@gilleslandais gilleslandais commented May 6, 2026

Description

This pull request is a direct follow-up for #19593

Fixes #19663

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim requested a review from bsipocz May 6, 2026 14:47
@pllim pllim added this to the v8.0.0 milestone May 6, 2026
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed backport-v8.0.x on-merge: backport to v8.0.x labels May 6, 2026
@pllim
Copy link
Copy Markdown
Member

pllim commented May 6, 2026

Thank you!

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gilleslandais unfortunately this doesn't do what it's supposed to do; the previous code should run, but have deprecation warnings.

We already have those deprecations in place, so we just need to make sure to use rather than override them.

@gilleslandais
Copy link
Copy Markdown
Contributor Author

I hope it isok now (it was a bad usage of deprecated_attribute)

@pllim
Copy link
Copy Markdown
Member

pllim commented May 15, 2026

@bsipocz does this look good to you now? We need to ship beta soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v8.0.x on-merge: backport to v8.0.x io.votable no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Dataorigin1.2 deprecation needs to be backward compatible

3 participants