Skip to content

TST: Add back ignoring socket warnings of yore - #19610

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
pllim:tst-ignore-socket
Apr 29, 2026
Merged

TST: Add back ignoring socket warnings of yore#19610
neutrinoceros merged 1 commit into
astropy:mainfrom
pllim:tst-ignore-socket

Conversation

@pllim

@pllim pllim commented Apr 29, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to add back some ignoring of socket warnings that was removed at some point but now they crept back in so I copied these back from the v6.1.x branch.

Fixes #19511

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim
TST: Add back ignoring socket warnings of yore
8f1e413 
that was removed at some point but now they crept back in so I copied these back from the v6.1.x branch
@pllim pllim added this to the v7.2.1 milestone Apr 29, 2026
@pllim
pllim requested a review from neutrinoceros as a code owner April 29, 2026 02:14
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Apr 29, 2026
Closed
@pllim

pllim commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

Remote data job passed but we can never be sure if I am just lucky here or I actually fixed it. 🤷‍♀️

@neutrinoceros

neutrinoceros commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

very unlikely that this is mere luck. This job has been consistently failing for a couple weeks.

neutrinoceros
neutrinoceros approved these changes Apr 29, 2026
View reviewed changes

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's run with this for now. In the long run, I'd like to fix this upstream if I can locate the problem in fsspec, but it's a long shot.

@neutrinoceros
neutrinoceros merged commit 1f9404e into astropy:main Apr 29, 2026
47 of 48 checks passed
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@pllim pllim mentioned this pull request Apr 29, 2026
Merged
1 task
@pllim
pllim deleted the tst-ignore-socket branch April 29, 2026 14:51
pllim added a commit that referenced this pull request Apr 29, 2026
@pllim
Merge pull request #19615 from neutrinoceros/bp/19610
326c39f 
Backport PR #19610 to v7.2.x (TST: Add back ignoring socket warnings of yore)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees

No one assigned

Labels

backport-v7.2.x on-merge: backport to v7.2.x no-changelog-entry-needed testing ¯\_(ツ)_/¯

Projects

None yet

Milestone

v7.2.1

Development

Successfully merging this pull request may close these issues.

TST: non-deterministic ResourceWarnings seen in Python 3.13 and 3.14 in CI with remote data

2 participants

@pllim @neutrinoceros