Skip to content

BUG: use non-deprecated numpy APIs to override dtype of a base column#19540

Merged
neutrinoceros merged 1 commit intoastropy:mainfrom
neutrinoceros:compat/numpy2.5/dtype-setter
Apr 9, 2026
Merged

BUG: use non-deprecated numpy APIs to override dtype of a base column#19540
neutrinoceros merged 1 commit intoastropy:mainfrom
neutrinoceros:compat/numpy2.5/dtype-setter

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Description

fixes an upcoming incompatibity that shows up in our tests suite with numpy dev + pandas
xref: numpy/numpy#29575

The change isn't in nightlies yet so this would likely fail devdeps at the time of opening. I'll undraft when it's ready.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

oh this does pass devdeps because this job doesn't include pandas. Welp, I guess I can undraft now then

@neutrinoceros neutrinoceros modified the milestones: v8.0.0, v7.2.1 Apr 8, 2026
@neutrinoceros neutrinoceros marked this pull request as ready for review April 8, 2026 09:04
@neutrinoceros neutrinoceros requested a review from taldcroft as a code owner April 8, 2026 09:04
@neutrinoceros
Copy link
Copy Markdown
Contributor Author

FTR, this is just the backport patch. It makes the deprecation invisible, but I also plan to open a follow up patch for 8.0.0 only, which will re-emit a new deprecation warning

Copy link
Copy Markdown
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and good plan to make the deprecation warning visible in 8.0 only.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Thanks. Let's get it in then.

@neutrinoceros neutrinoceros merged commit bf76f45 into astropy:main Apr 9, 2026
46 of 50 checks passed
@neutrinoceros neutrinoceros deleted the compat/numpy2.5/dtype-setter branch April 9, 2026 06:23
@lumberbot-app
Copy link
Copy Markdown

lumberbot-app bot commented Apr 9, 2026

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v7.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 bf76f45b1ec57c7f86ba6332db3e9ed552582dae
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #19540: BUG: use non-deprecated numpy APIs to override dtype of a base column'
  1. Push to a named branch:
git push YOURFORK v7.2.x:auto-backport-of-pr-19540-on-v7.2.x
  1. Create a PR against branch v7.2.x, I would have named this PR:

"Backport PR #19540 on branch v7.2.x (BUG: use non-deprecated numpy APIs to override dtype of a base column)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants