BUG: use non-deprecated numpy APIs to override dtype of a base column#19540
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
oh this does pass devdeps because this job doesn't include pandas. Welp, I guess I can undraft now then |
|
FTR, this is just the backport patch. It makes the deprecation invisible, but I also plan to open a follow up patch for 8.0.0 only, which will re-emit a new deprecation warning |
mhvk
left a comment
There was a problem hiding this comment.
Looks good, and good plan to make the deprecation warning visible in 8.0 only.
|
Thanks. Let's get it in then. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…Is to override dtype of a base column)
Description
fixes an upcoming incompatibity that shows up in our tests suite with numpy dev + pandas
xref: numpy/numpy#29575
The change isn't in nightlies yet so this would likely fail devdeps at the time of opening. I'll undraft when it's ready.