Skip to content

API: Deprecate astropy.samp#19373

Draft
pllim wants to merge 1 commit intoastropy:mainfrom
pllim:sampwise-gamgee
Draft

API: Deprecate astropy.samp#19373
pllim wants to merge 1 commit intoastropy:mainfrom
pllim:sampwise-gamgee

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Mar 6, 2026 •
edited
Loading

Description

This pull request is to deprecate astropy.samp formally in the same style as astropy/astroquery#3548

Close #9763

Blocked by

After merge

  • Open follow-up issue to complete remove astropy.samp from this repo. This also includes directive in auto-labeling bot, pytest warning filter, and so on. Some grep-fu required.

@pllim pllim added this to the v9.0.0 milestone Mar 6, 2026
@pllim pllim added API change PRs and issues that change an existing API, possibly requiring a deprecation period Downstream Fix Required labels Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim force-pushed the sampwise-gamgee branch from 2f28a33 to e990e72 Compare March 6, 2026 23:09
@pllim pllim mentioned this pull request Mar 6, 2026
Merged
@pllim

This comment was marked as resolved.

Sign in to view
bsipocz
bsipocz reviewed Mar 6, 2026
View reviewed changes
Comment thread astropy/samp/__init__.py
# Licensed under a 3-clause BSD style license - see LICENSE.rst
"""
.. warning::
``astropy.samp`` was deprecated in version 9.0 and will be removed in a future version;
Copy link
Copy Markdown
Member

@bsipocz bsipocz Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in 8.1?

Copy link
Copy Markdown
Member Author

@pllim pllim Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can re-milestone when we know for sure. When will pyvo be released again?

Copy link
Copy Markdown
Member

@bsipocz bsipocz Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the next ivoa, so practically end of May, very early june

Copy link
Copy Markdown
Member Author

@pllim pllim Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK we can revisit after that. Thanks!

@pllim pllim force-pushed the sampwise-gamgee branch from a8d7215 to 74d0868 Compare March 7, 2026 02:41
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Mar 7, 2026

Remote data job failure is unrelated.

@pllim pllim mentioned this pull request Mar 10, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz left review comments

@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros will be requested when the pull request is marked ready for review neutrinoceros is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period Docs Downstream Fix Required samp

Projects

None yet

Milestone

v9.0.0

Development

Successfully merging this pull request may close these issues.

Move samp to PyVO package

2 participants

@pllim @bsipocz