Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

This is causing failures against numpy nightlies, which are not yet caught up with the changes I'm adapting to. It might be easier to wait a couple days to validate this in CI directly.

(Of course I did try it locally. It might however turn out incomplete by the time a new nightly happens, if any other breaking change is merged in the interval)

No worries. I didn't mean to suggest otherwise

New nightlies are out. I'm re-running failed jobs manually.

Everything's green, save for codecov, which I think we can ignore. Merging now so allowed-failure jobs have a chance to pass on other PRs. Thanks all !

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v7.1.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 2309a502d14d28319aabbb75b52adfed49366042

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #18732: BUG: fix incoming incompatibilities with numpy 2.4'

4. Push to a named branch:

git push YOURFORK v7.1.x:auto-backport-of-pr-18732-on-v7.1.x

5. Create a PR against branch v7.1.x, I would have named this PR:

"Backport PR #18732 on branch v7.1.x (BUG: fix incoming incompatibilities with numpy 2.4)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

manual backport at #18751

Thank you!