Add unit_support() to enable quantity and time support together by elmostafa-abdelaal · Pull Request #17979 · astropy/astropy

elmostafa-abdelaal · 2025-04-05T00:34:49Z

Description

This pull request is to fix #8860

Alternative to #17575

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2025-04-05T00:35:15Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.

neutrinoceros

Hi @elmostafa-abdelaal, thanks for your contribution and sorry for the long wait !
I pointed a couple undue changes in your PR, but the most important thing is that it's missing a test. Please let us know if you need help writing one. Thank you !

neutrinoceros · 2025-07-09T14:16:34Z

We do not edit this file directly in PRs. Instead, please add a note as a new file, as described in docs/changes/README.rst.

neutrinoceros · 2025-07-09T14:17:32Z

 import numpy as np

-__all__ = ["quantity_support"]
+__all__ = ["quantity_support", "unit_support"]  # ✅ أضفنا unit_support هنا


We only allow comments in english, so most contributors can understand them

Suggested change

__all__ = ["quantity_support", "unit_support"] # ✅ أضفنا unit_support هنا

__all__ = [

"quantity_support",

"unit_support",

]

neutrinoceros · 2025-07-09T14:18:05Z

      ...     plt.figure()
      ...     plt.plot([1, 2, 3] * u.m)
-      [...]
+      ...


please revert this line

neutrinoceros · 2025-07-09T14:18:11Z

+      ...
      ...     plt.plot([101, 125, 150] * u.cm)
-      [...]
+      ...


this one too

neutrinoceros · 2025-07-09T14:18:54Z

+    """
+    Enable both quantity and time support for matplotlib.
+
+    This is a convenience function that enables both astropy's


I don't recall seeing that style in our docs, let's avoid it

Suggested change

This is a convenience function that enables both astropy's

This is a convenience function that enables both

neutrinoceros · 2025-07-09T14:19:35Z

this file also shouldn't be updated in this PR

neutrinoceros · 2025-07-09T14:20:50Z

+.. function:: unit_support(format="latex_inline")
+
+   Enable both quantity and time support for matplotlib.
+
+   :param format: Format for unit labels (default: 'latex_inline').
+   :returns: Context manager enabling both supports.


I don't think this is needed: ref_api will automatically generate the text we want to include here

github-actions · 2025-09-02T05:45:55Z

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

github-actions · 2025-10-03T05:42:35Z

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

Add unit_support() to enable quantity and time support together

72dadca

elmostafa-abdelaal requested review from astrofrog and larrybradley as code owners April 5, 2025 00:34

github-actions Bot added the visualization label Apr 5, 2025

github-actions Bot reviewed Apr 5, 2025

View reviewed changes

merge all function

1802c67

pllim added this to the v7.1.0 milestone Apr 5, 2025

elmostafa-abdelaal added 4 commits April 5, 2025 03:14

pre-commite check

3c27769

check

5da5041

check

6fefedb

whats new

e4d0027

astrofrog modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025

Subham-KRLX mentioned this pull request Jul 2, 2025

Provide a way to enable both quantity_support and time_support in one go #8860

Open

neutrinoceros requested changes Jul 9, 2025

View reviewed changes

github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Sep 2, 2025

github-actions Bot added the closed-by-bot Closed by stale bot label Oct 3, 2025

github-actions Bot closed this Oct 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add unit_support() to enable quantity and time support together#17979

Add unit_support() to enable quantity and time support together#17979
elmostafa-abdelaal wants to merge 6 commits into
astropy:mainfrom
elmostafa-abdelaal:astro-support-function

elmostafa-abdelaal commented Apr 5, 2025 •

edited by pllim

Loading

Uh oh!

github-actions Bot commented Apr 5, 2025

Uh oh!

github-actions Bot left a comment

Uh oh!

neutrinoceros left a comment

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

neutrinoceros Jul 9, 2025

Uh oh!

github-actions Bot commented Sep 2, 2025

Uh oh!

github-actions Bot commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	This is a convenience function that enables both astropy's
	This is a convenience function that enables both

Uh oh!

Conversation

elmostafa-abdelaal commented Apr 5, 2025 • edited by pllim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions Bot commented Apr 5, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

neutrinoceros left a comment

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

neutrinoceros Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 2, 2025

Uh oh!

github-actions Bot commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elmostafa-abdelaal commented Apr 5, 2025 •

edited by pllim

Loading