Skip to content

Allow Masked instances as input for sigma clipping#16876

Closed
mhvk wants to merge 3 commits into
astropy:mainfrom
mhvk:sigma-clip-with-masked
Closed

Allow Masked instances as input for sigma clipping#16876
mhvk wants to merge 3 commits into
astropy:mainfrom
mhvk:sigma-clip-with-masked

Conversation

@mhvk
Copy link
Copy Markdown
Contributor

@mhvk mhvk commented Aug 23, 2024

This pull request is to ensure that sigma clipping understands Masked instances -- part of the project to ensure that Masked can be used throughout astropy.

It also fixes a small buglet in Masked, where if trying to determine the underlying data from a MaskedColumn, it would return a MaskedArray (because MaskedColumn overrides data). stats had a work-around for that which is now no longer needed.

Note that this builds on #16875, so one can ignore the first commit. EDIT: with #16875 merged, this now stands on its own.

Opening as draft as I'm not sure the test coverage is quite up to snuff - I just made any tests with MaskedArray also run with Masked.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@mhvk mhvk added utils and removed units labels Aug 26, 2024
@mhvk mhvk force-pushed the sigma-clip-with-masked branch from 5fc5473 to 7e56468 Compare August 26, 2024 20:20
@mhvk mhvk force-pushed the sigma-clip-with-masked branch from 7e56468 to 47b3ef6 Compare September 15, 2024 19:23
@mhvk
Copy link
Copy Markdown
Contributor Author

mhvk commented Sep 15, 2024

@larrybradley - would be great if you could give a sense of whether you feel this PR (which allows sigmaclip to deal with Masked) is going in the right direction. It may also need some decisions: e.g., should one return Masked if the input uses that (instead of np.ma.MaskedArray).

@larrybradley
Copy link
Copy Markdown
Member

I think it's reasonable to return Masked for Masked input.

@pllim
Copy link
Copy Markdown
Member

pllim commented Oct 10, 2024

@mhvk , should we move the milestone to v7.1 ?

@mhvk
Copy link
Copy Markdown
Contributor Author

mhvk commented Oct 11, 2024

@mhvk , should we move the milestone to v7.1 ?

Yes, this is far from critical, and my schedule is unpleasantly full the coming weeks.

@mhvk mhvk modified the milestones: v7.0.0, v7.1.0 Oct 11, 2024
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Feb 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@github-actions github-actions Bot added the closed-by-bot Closed by stale bot label Mar 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close? Tell stale bot that this issue/PR is stale closed-by-bot Closed by stale bot Enhancement stats utils.masked utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants