Allow Masked instances as input for sigma clipping#16876
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
5fc5473 to
7e56468
Compare
7e56468 to
47b3ef6
Compare
|
@larrybradley - would be great if you could give a sense of whether you feel this PR (which allows |
|
I think it's reasonable to return |
|
@mhvk , should we move the milestone to v7.1 ? |
Yes, this is far from critical, and my schedule is unpleasantly full the coming weeks. |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
This pull request is to ensure that sigma clipping understands
Maskedinstances -- part of the project to ensure thatMaskedcan be used throughout astropy.It also fixes a small buglet inMasked, where if trying to determine the underlying data from aMaskedColumn, it would return aMaskedArray(becauseMaskedColumnoverridesdata).statshad a work-around for that which is now no longer needed.Note that this builds on #16875, so one can ignore the first commit.EDIT: with #16875 merged, this now stands on its own.Opening as draft as I'm not sure the test coverage is quite up to snuff - I just made any tests with
MaskedArrayalso run withMasked.