Repository navigation
[ty] Avoid definition lookups in recursive TypedDict comparisons - #30444
Draft
charliermarsh wants to merge 2 commits into
Draft
charliermarsh wants to merge 2 commits into
charliermarsh wants to merge 2 commits into
Conversation
When testing whether two active types could have the same recursive identity, compare their static class body scopes. The scope already identifies the class definition; fetching the definition via the semantic index is unnecessary. Synthesized and dynamic TypedDicts use exact identity, which has already been checked.
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for 5d9752c · Workflow run |
Contributor
Memory usage reportMemory usage unchanged ✅ Results for 5d9752c · Workflow run |
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When ty compares two
TypedDicts, it checks whether it has already seen the same recursive comparison. Just ruling out a match used to require looking up both class definitions in the semantic index. On Pydantic, this was hot even when comparing unrelated classes.We now compare the class body scopes directly. Each static class has its own body scope, even if decorators change the inferred class. The cycle detector still confirms a possible match as before. No new cache is needed.