Repository navigation
[flake8-bandit, flake8-async] Extend to cover httpx2 - #30442
Open
StefanBRas wants to merge 2 commits into
Open
StefanBRas wants to merge 2 commits into
StefanBRas wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #28063
Extends the following rules to also cover calls made with
httpx2:To the best of my knowledge, these are all the rules related to
httpxNotes to reviewers
I'm not sure if you would like another approach in
crates/ruff_linter/src/rules/flake8_async/rules/blocking_http_call_httpx.rs. It might look like I try to be fancy, but I weren't sure how to return the specific package while still upholding the signature for theTypeCheckertrait.All tests are just the already existing httpx ones duplicated and renamed.
AI disclosure: No AI.