Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#3712.
With
completions.completeFunctionParenthesesenabled, accepting a class completion also inserts(). For enums that is almost never what the user wants: typingColoris nearly always a step towardsColor.RED, andColor()both discards the member access and puts the cursor inside the parentheses.Class completions for enum classes now skip the parentheses. This covers
Enum,StrEnum,IntEnum, enum subclasses and subclasses of subclasses; non-enum classes are unchanged.This follows the approach a maintainer suggested in the issue — @MichaReiser:
It also picks up #25832, which tried the same thing but was closed before merging.
Test Plan
New snapshot tests in
crates/ty_ide/src/completion.rscoverEnum, an enum subclass, a subclass of a subclass,StrEnumandIntEnum, plus the existingcomplete_class_parenthesestest for a plain class.cargo test -p ty_ide --libcargo test -p ty_server --test e2e completions