Repository navigation
[ty] Rename implicit-concatenated-string-type-annotation to implicit-string-concatenation-in-type-annotation - #30286
Draft
AlexWaygood wants to merge 1 commit into
Draft
AlexWaygood wants to merge 1 commit into
AlexWaygood wants to merge 1 commit into
Conversation
…it-string-concatenation-in-type-annotation`
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for c664beb · Workflow run |
Contributor
Memory usage reportMemory usage unchanged ✅ Results for c664beb · Workflow run |
Contributor
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
implicit-concatenated-string-type-annotation |
0 | 5 | 0 |
implicit-string-concatenation-in-type-annotation |
5 | 0 | 0 |
| Total | 5 | 5 | 0 |
Large timing changes:
| Project | Old Time | New Time | Change |
|---|---|---|---|
packaging |
0.07s | 0.10s | +50% |
Raw diff:
pandas (https://github.com/pandas-dev/pandas)
- pandas/core/tools/datetimes.py:1268:17 error[implicit-concatenated-string-type-annotation] Type expressions cannot span multiple string literals
+ pandas/core/tools/datetimes.py:1268:17 error[implicit-string-concatenation-in-type-annotation] Type expressions cannot span multiple string literals
pytest-autoprofile (https://gitlab.com/TTsangSC/pytest-autoprofile)
- src/pytest_autoprofile/profiler.py:68:11 error[implicit-concatenated-string-type-annotation] Type expressions cannot span multiple string literals
+ src/pytest_autoprofile/profiler.py:68:11 error[implicit-string-concatenation-in-type-annotation] Type expressions cannot span multiple string literals
- tests/test-modules-and-tests/test_subprocess/packages/myfork.py:80:21 error[implicit-concatenated-string-type-annotation] Type expressions cannot span multiple string literals
+ tests/test-modules-and-tests/test_subprocess/packages/myfork.py:80:21 error[implicit-string-concatenation-in-type-annotation] Type expressions cannot span multiple string literals
- tests/test-modules-and-tests/test_subprocess/packages/myprocess.py:134:17 error[implicit-concatenated-string-type-annotation] Type expressions cannot span multiple string literals
+ tests/test-modules-and-tests/test_subprocess/packages/myprocess.py:134:17 error[implicit-string-concatenation-in-type-annotation] Type expressions cannot span multiple string literals
trio (https://github.com/python-trio/trio)
- src/trio/testing/_raises_group.py:532:13 error[implicit-concatenated-string-type-annotation] Type expressions cannot span multiple string literals
+ src/trio/testing/_raises_group.py:532:13 error[implicit-string-concatenation-in-type-annotation] Type expressions cannot span multiple string literalsFull report with detailed diff · Timing results
Results for c664beb · Workflow run
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the rule to better conform to Ruff’s rule naming convention. In
value: "in" "t", ty flags the implicit string concatenation. The new name puts that operation first and identifies the type annotation as the place where it occurs.implicit-concatenated-string-type-annotationremains a compatibility alias for existing configuration and suppression comments.