Repository navigation
Conversation
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for 4a8dbdc · Workflow run |
Contributor
Memory usage reportSummary
Significant changesClick to expand detailed breakdowntrio
prefect
Results for 4a8dbdc · Workflow run |
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
Reader.__init__annotatesselfasReader[bool | None], assigningReader()to a variable of typeReader[bool]can silently dropNone.Alternative to #30179 for astral-sh/ty#4977. This approach keeps the constructor result generic during contextual inference. The receiver argument already requires
Reader[T]to be assignable toReader[bool | None]. When inferring a bare constructor against an expected type, also requireReader[bool | None]to be assignable to the inferred resultReader[T]. For a covariant reader this supplies the missing lower bound onT, so the assignment reportsinvalid-assignment.For an inherited initializer, first express the annotated result as a specialization of the subclass. Type arguments that the initializer leaves open can still come from the assignment. This also preserves the existing inference of
X[Any]forx: X[Any] = X()withself: X[None].Test plan
Regression cases cover mixed-variance fields in both generic syntaxes, explicit specialization, and inherited initializers.