add Australian number: ABN, ACN, TFN#40
Conversation
|
Thanks for your contribution. There are a few minor bugs in your code but those are easily fixed. Could you provide some small bit of text for each module's docstring? Perhaps with a pointer to more information. Also do you know of any public registry or source of valid numbers of each type? For these kind of numbers I generally run tests against a large collection of found numbers and include a few in the test suite to try to avoid bugs (e.g. some numbers are documented to have a checksum but a significant percentage of real numbers fail the checksum test). Thanks! |
|
Sorry about the bugs. I'll update the branch with text for each module's docstring. I'll have a look at what I can get for you, but as far as I understand it there should not be any exceptions to the checksum. Link for valid ACN's - http://asic.gov.au/for-business/starting-a-company/how-to-start-a-company/australian-company-numbers/australian-company-number-digit-check/ Links with information or validator - |
Based on the implementation provided by Vincent Bastos <vincent@lavalab.com.au> See #40
Based on the implementation provided by Vincent Bastos <vincent@lavalab.com.au> See #40
Based on the implementation provided by Vincent Bastos <vincent@lavalab.com.au> See #40
|
Ah sorry Arthur! Thanks for closing that one off. |
Although support for Australian ABN was added in stdnum 1.5 (arthurdejong/python-stdnum#40) it was in a bespoke module, which only got aliased to VAT in 1.15 (arthurdejong/python-stdnum#246), therefore a shim was necessary to bridge the two. Since Odoo now requirements stdnum 1.17, it should not be necessary anymore.
Although support for Australian ABN was added in stdnum 1.5 (arthurdejong/python-stdnum#40) it was in a bespoke module, which only got aliased to VAT in 1.15 (arthurdejong/python-stdnum#246), therefore a shim was necessary to bridge the two. Since Odoo now requirements stdnum 1.17, it should not be necessary anymore. Part-of: #175008 Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
Hey - Just thought I would add some Australian numbers to your module.