Skip to content

Add some new VAT numbers for GB#4

Closed
cedk wants to merge 3 commits into
arthurdejong:masterfrom
cedk:master
Closed

Add some new VAT numbers for GB#4
cedk wants to merge 3 commits into
arthurdejong:masterfrom
cedk:master

Conversation

@cedk

@cedk cedk commented Dec 30, 2013

Copy link
Copy Markdown
Contributor

Add support for restarting from November 2009 using 9755.
Add support for EU format of health authorities

cedk added 2 commits December 30, 2013 16:37
Add support for restarting from November 2009 using 9755.
Add support for EU format of health authorities
@arthurdejong

Copy link
Copy Markdown
Owner

Thanks for your pull request. It looks very good. There is only one issue: some of the corner cases remain untested which results in not having 100% test coverage.

There are missing tests for the 11-digit HA/GD format and for the failures of the restarting numbers.

You can run the tests with nosetests and it should create a coverage directory with a report in it.

I have merged your proxy support commit but I've moved the import from urllib to avoid loading too many other modules that are not used a lot.

arthurdejong pushed a commit that referenced this pull request Dec 30, 2013
Add support for restarting from November 2009 using 9755.
Add support for EU format of health authorities

See: #4
@arthurdejong

Copy link
Copy Markdown
Owner

Thanks for your contrinution. I've combined the commits into a148835.

cedk pushed a commit to cedk/python-stdnum that referenced this pull request Dec 18, 2025
cedk pushed a commit to cedk/python-stdnum that referenced this pull request Dec 18, 2025
Improve for: Issue arthurdejong#6: Custom text not allowed under barcode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants