Add CC (Número de Cartão de Cidadão, Portuguese Identity number)#265
Closed
davidmgvaz wants to merge 2 commits into
Closed
Add CC (Número de Cartão de Cidadão, Portuguese Identity number)#265davidmgvaz wants to merge 2 commits into
davidmgvaz wants to merge 2 commits into
Conversation
…_digit minor text corrections
Contributor
Author
|
I have already corrected the two typos you found and also split the calck_check_digit to an autonomous function, as I saw that was the standard practice |
Owner
|
Hi @davidmgvaz Thanks for the contribution. Could you provide some test numbers that can be used to confirm the implementation? For most number formats we have a number of tests with valid numbers to be able to validate the correctness of the calculations. |
Owner
|
Also a part of the number is a Número de Identificação Civil which has its own check digit. Do you have any idea (or pointers) how to validate that number? |
|
@arthurdejong any particular reason to not update the README? |
Owner
|
The README and documentation are updated as part of the release process with update/numlist.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds CC (Número de Cartão de Cidadão, Portuguese Identity number)