Add ISRC (International Standard Recording Code)#261
Closed
nuno-andre wants to merge 1 commit into
Closed
Conversation
Owner
|
Hi @nuno-andre, Thanks for providing the number format. I've merged it as 36d723c. I took out the If there are any formats missing I would welcome pull requests but creating issues with a request for the format is also fine. In general, python-stdnum is meant to be used in situations like with Pydantic (didn't know about that library before). I recommend calling Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds support for the ISRC (International Standard Recording Code).
I've also added a little function to
util.pythat I often use to split strings into different sizes. I think it could be useful for other codes. If you think that it's misplaced or misnamed I have no problem in modifying the commit.Also, comment that I'm writing a wrapper to use python-stdnum with Pydantic (Pydentic). I have a little library with some validators for Pydantic models, and I've found that yours has almost all of them (and many more), so I think it's way more productive to add the missing ones to python-stdnum and wrap it up. Currently, it is little more than a proof of concept but I will develop it in the next few days, and will also send some more PRs if you like.
Thanks for your work, it's really amazing. I wish I had known about it sooner :)