Skip to content

Adds the Swiss social security number.#16

Closed
href wants to merge 1 commit into
arthurdejong:masterfrom
seantis:master
Closed

Adds the Swiss social security number.#16
href wants to merge 1 commit into
arthurdejong:masterfrom
seantis:master

Conversation

@href

@href href commented Oct 13, 2014

Copy link
Copy Markdown
Contributor

Let me know if there's anything lacking!

Many thanks for python-stdnum.

@arthurdejong

Copy link
Copy Markdown
Owner

Looks very good. A few minor points:

  • you should fix the copyright headers (add your own name and the current year there)
  • stdnum/ch/init.py is missing a newline at the end of the file
  • the format function can be shortened a bit to:
    return '.'.join((number[:3], number[3:7], number[7:11], number[11:]))
    (this also ensures the line doesn't become too long fof pep8)
  • try to keep your commit message subject short
  • the rst file is not really necessary unless you provide some extra documentation for the module

The first point is the only real important one.

@href href force-pushed the master branch 2 times, most recently from 09b58aa to 39f292d Compare October 18, 2014 15:47
Also known as "Sozialversicherungsnummer" / "Neue AHV Nummer".
@href

href commented Oct 18, 2014

Copy link
Copy Markdown
Contributor Author

I amended my commit with your suggestions. Though the newlines don't show up on Github for some reason.

@arthurdejong

Copy link
Copy Markdown
Owner

I've merged your changes in 256aa49. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants