Skip to content

remove deepcopy calls #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ran404 merged 2 commits into from
Sep 11, 2018
Merged

remove deepcopy calls #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9bdf2e
update license
ran404 Aug 29, 2018
7e21b71
no need to deep copy as plotly api does it for us
ran404 Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2017 arraystream
Copyright (c) 2017 ArrayStream Technologies

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
5 changes: 2 additions & 3 deletions weplot/figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import copy
import itertools

import plotly
Expand Down Expand Up @@ -118,7 +117,7 @@ def build_subplot(self, print_grid=True, **kwargs):

for idx, builder in enumerate(self.builders):
spec = self.canvas.specs[idx]
fig.append_trace(copy.deepcopy(builder.data), spec.r, spec.c)
fig.append_trace(builder.data, spec.r, spec.c)

holder = FigureHolder(go.Figure(data=fig.data, layout=fig.layout))
holder.update_layout(**self.layout)
Expand All @@ -129,7 +128,7 @@ def subplot(self, row=None, col=None, print_grid=True, **kwargs):
if col is not None and row is not None:
new_builder = FigureBuilder()
new_builder.builders = self.builders
new_builder.layout = copy.deepcopy(self.layout)
new_builder.layout = self.layout
new_builder.canvas = canvas_from_specs(itertools.product(range(1, row + 1), range(1, col + 1)))
new_builder.build_subplot(print_grid=print_grid, **kwargs).plot()
else:
Expand Down