Try PkgConf first to find CBLAS#989
Closed
marbre wants to merge 1 commit into
Closed
Conversation
Member
|
We can't have PkgConf as REQUIRED on windows. It needs to be optional and only be enabled on Linux systems. |
Contributor
Author
|
Thanks for the comment. Removed REQUIRED and made PKG_CHECK_MODULES optional like in FindLAPACKE.cmake. |
Contributor
Author
Member
|
@marbre Sorry to do this again, I think the commits need to go to hotfixes-3.1.1 instead of devel. |
Contributor
Author
|
@pavanky No problem. Done so for the FindLAPACKE.cmake PR too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite similar to PR #988. This fixes issue #761. Any feedback is appreciated.