Implementation of SVD for all backends#969
Merged
Merged
Conversation
Member
pavanky
commented
Aug 25, 2015
- Fixes SVD for all backends #862
- Fixes GCC compiler warnings #709
SVD for CPU and CUDA backends
- gebrd_hybrid - labrd_gpu
- Compiles and runs but errors out at certain sizes
Member
Author
|
@shehzan10 The OpenCL backend right now requires CBLAS as well. Can you update our jenkins jobs appropriately ? |
Member
Author
|
@klemmster The merge is finally coming into devel :) I had to change the API a little bit from the SVD branch.. The order of the outputs is now This was done to reflect the order in which they should be multiplied to reconstruct the original result. I hope this does not break too much on your end. |
Member
|
OSX requires you to define the following LAPACKE->LAPACK interfaces in src/backend/lapacke:
I think that's the list from the errors I see. |
Member
|
I'm checking to see why linux is failing. We use MKL for PR builds. |
This reverts commit b6d8e2d. This commit was causing performance drops on certain hardware
Member
|
OSX-x64 is expected to fail svd_dense_opencl. I have added the exclusion to the PR builder. |
- complex versions of GESDD were segfaulting
shehzan10
added a commit
that referenced
this pull request
Aug 25, 2015
Implementation of SVD for all backends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.