Repository navigation
fix(oneapi): account for indexed subarray offset - #3737
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3733.
Description
The oneAPI index kernel reads from the underlying buffer using view-relative indices but omits
Param::offset. Indexing a non-zero-offset subarray with an index array therefore reads from the beginning of the parent array. Include the input buffer offset when calculating the source pointer, and add a regression test for indexing a slice with indices{0, 1, 2, 3}.Validation
git diff --checkpassed. The ArrayFire test/build suite was not run: this environment has no CMake or C++ compiler/SYCL toolchain, and the assigned task prohibits using real GPU hardware. The regression test is committed for execution by the project’s backend test setup.Changes to Users
None; this restores the documented view-relative indexing behavior.
Checklist